Warning when calling `read` method of Stream class with 0 length about psr7 HOT 4 CLOSED

I agree that there is a problem. \Psr\Http\Message\StreamInterface::read should return a string or throw an exception. Both are not done because it causes a warning and returns false because fread returns false in this case. There are two solutions:

1. ignore length of 0 an return '' as you suggested,
2. transform the warning to an exception, so length of 0 will still fail.

Considering the use-case you gave above makes sense I tend to favor solution 1) because reading 0 bytes seems useless but is not an error.
I also checked other Stream APIs like the underlying C API, and nodejs, and Java, and Go. None of them throw an exception when reading with length of 0.

from psr7.

Thank you @Tobion
Do I need to create merge request?

from psr7.

Would be nice if you create a PR. When length === 0, return ''. And also check if fread returns false and throw an exception then. So a negative length will still fail.

from psr7.

@Tobion Thank you

from psr7.