Giter Club home page Giter Club logo

Comments (5)

Tobion avatar Tobion commented on May 1, 2024 1

Feel free to create a PR. The change is really simple.

from psr7.

pkruithof avatar pkruithof commented on May 1, 2024

ping @mtdowling @Tobion

from psr7.

Tobion avatar Tobion commented on May 1, 2024

From what I infer from your description is that you are not using the Guzzle base_uri config option but instead have your own middleware that resolves the /foo URI?
And in your middleware you will receive http:/foo as URI due to the added scheme.

The resolve method should not be changed because it is according to a standard. What we can change is that the http scheme in https://github.com/guzzle/guzzle/blob/master/src/Client.php#L148 is only added if the URI has a host at all.

from psr7.

pkruithof avatar pkruithof commented on May 1, 2024

From what I infer from your description is that you are not using the Guzzle base_uri config option but instead have your own middleware that resolves the /foo URI?

Correct.

What we can change is that the http scheme in https://github.com/guzzle/guzzle/blob/master/src/Client.php#L148 is only added if the URI has a host at all.

That would be great, yes. Should I open a new issue in that repo?

from psr7.

pkruithof avatar pkruithof commented on May 1, 2024

Right, done: guzzle/guzzle#1565

from psr7.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.