Giter Club home page Giter Club logo

Comments (4)

ashgibson avatar ashgibson commented on May 5, 2024

The update for the package to work with Guzzle 6 should probably be a new major version or a separate package altogether due to the breaking changes?

from oauth-subscriber.

mtdowling avatar mtdowling commented on May 5, 2024

I don't see a reason for this. A guzzle 5 compatible version will not be maintained, so you should just lock your dependency to a specific SHA if you'd like.

The update for the package to work with Guzzle 6 should probably be a new major version or a separate package altogether due to the breaking changes?

This package is unstable and never had a major release (i.e., it's still 0.x.x), so major for this package is a minor version bump.

from oauth-subscriber.

merk avatar merk commented on May 5, 2024

Because locking at a specific SHA commit will not work - the composer.json file dependencies cause a failure if you do so.

Lack of maintenance is fine, but supporting backwards compatibility is important especially after such major changes to Guzzle - what happens when you go to 7 and make the same decision?

{
    "require": {
        "guzzlehttp/guzzle": "5.*",
        "guzzlehttp/oauth-subscriber": "dev-master#55c001f5cbcfab5f44792426538cba5bd53168f2"
    }
}
➜  guzzle-oauth-test  composer install
Loading composer repositories with package information
Installing dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for guzzlehttp/oauth-subscriber dev-master#55c001f5cbcfab5f44792426538cba5bd53168f2 -> satisfiable by guzzlehttp/oauth-subscriber[dev-master].
    - guzzlehttp/oauth-subscriber dev-master requires guzzlehttp/guzzle ~6.0 -> no matching package found.

Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setting
   see <https://groups.google.com/d/topic/composer-dev/_g3ASeIFlrc/discussion> for more details.

Read <https://getcomposer.org/doc/articles/troubleshooting.md> for further common problems.

from oauth-subscriber.

merk avatar merk commented on May 5, 2024

A trivial branch-adjust dependencies-tag action removes the problem entirely, and would be appreciated. Workarounds like defining an additional repository like below would then be unnecessary.

{
    "repositories": [
        {
            "type": "package",
            "package": {
                "name": "guzzlehttp/oauth-subscriber",
                "version": "0.2.99",
                "dist": {
                    "url": "https://github.com/guzzle/oauth-subscriber/archive/55c001f5cbcfab5f44792426538cba5bd53168f2.zip",
                    "type": "zip"
                }
            }
        }
    ]
}

from oauth-subscriber.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.