mitm.bypass() stops working after changing the event name in the handler. about failure-lambda HOT 4 CLOSED

Got it. I haven't seen that behavior, so need to run some tests to confirm it. Thanks!

from failure-lambda.

I've confirmed the behavior and switched back to connect for now. New issue created for the problem with enable/disable: #16

from failure-lambda.

Sorry for the late reply.

Using connect has meant that enabling/disabling the failure mode has been difficult only using the parameter. It has basically meant that you need to refresh the function container (update, redeploy, new cold start, etc) for the enable/disable to take effect. That was the reason to move to connection, since that allowed us to enable/disable denylist simply by changing the parameter.

Do you mean that it's blocking all network connections, not only those in the denylist? The functionality should be to block the hosts in the denylist only.

if (block) { //Should catch the hosts in the denylist
socket.end()
} else { //Should catch everything else
socket.bypass()
}

from failure-lambda.

Hi,
I see, the idea is clear, but it blocks all connections and not only supposed one from denylist.

when we call socket.bypass()(behind the scene the method just change the flag .bypassed to true) in onConnectionHandler, then the flag bypassed will be never checked/used in node-mitm and it leads to blocking all request because the original request is not called anymore.

Or do I miss anything?

from failure-lambda.