Need add rxjs 7 support for version 9.x.x about ng-dynamic-component HOT 14 CLOSED

@gund Yes, sure
Built and check in storybook, works great!

from ng-dynamic-component.

@gund
Yes, I understand.
I will wait update to Angular 13.

This crutch is not needed anymore

from ng-dynamic-component.

Yes I think at the time when v9 was release there probably was no rxjs v7 yet.

But you should have no problem using rxjs v7 even with v9, just disable NPM from checking peer dependencies (either via --legacy-peer-deps or --force) and install rxjs v7 manually.
Ideally you could just update the lib to v10 which includes rxjs v7 (compatible with Angular v12+).

But I'm not planning on maintaining previous major versions which means anything below v10 does not get any updates as this will increase the burden of maintenance of the library.

from ng-dynamic-component.

Ok, I understand you.

Unfortunately, v10 does not work with angular 12. And I can't update up to 13, because we need support IE =(

from ng-dynamic-component.

@gund does v10 could work with angular 12? I try and got error in runtime, when create component.
Here https://github.com/gund/ng-dynamic-component/blob/v10.2.0-next.1/projects/ng-dynamic-component/src/lib/dynamic.component.ts#L67

Angular 12 have another signature of this method.

from ng-dynamic-component.

Oh yes, I forgot about that change, I will need to add backwards compatibility for that piece of code.
I'm going to release it under next tag so you could check it if it works or something else need backwards compatibility fixes.

from ng-dynamic-component.

Great! Thank you very much

from ng-dynamic-component.

@DexterIA could you please give a try to 10.2.0-next.2 and see if it will work with Angular v12?

from ng-dynamic-component.

This has been released on 10.2.0

from ng-dynamic-component.

@gund
Something goes wrong...

I've got error when build app, after update to 10.2.0

TypeError: Cannot create property 'message' on string '.\node_modules\ng-dynamic-component\fesm2015\ng-dynamic-component.mjs: This application depends upon a library published using Angular version 14.0.1, which requires Angular version 14.0.0 or newer to work correctly.

Consider upgrading your application to use a more recent version of Angular.
  26 | }
  27 | /** @nocollapse */ ComponentOutletInjectorDirective.ɵfac = i0.ɵɵngDeclareFactory({ minVersion: "12.0.0", version: "14.0.1", ngImport: i0, type: ComponentOutletInjectorDirective, deps: [{ token: i1.NgComponentOutlet, host: true }], target: i0.ɵɵFactoryTarget.Directive });
> 28 | /** @nocollapse */ ComponentOutletInjectorDirective.ɵdir = i0.ɵɵngDeclareDirective({ minVersion: "14.0.0", version: "14.0.1", type: ComponentOutletInjectorDirective, selector: "[ngComponentOutlet]", providers: [
     |                                                            ^
  29 |         {
  30 |             provide: DynamicComponentInjectorToken,
  31 |             useExisting: ComponentOutletInjectorDirective,'

Look's like it work only in Angular 14

Interesting, storybook build completes without errors and components work's fine.

from ng-dynamic-component.

Hmm that looks strange, this seems like a specific version check during a build time as there is no hard dependency on Angular v14 in the library.
Not really sure how to resolve this issue.

@DexterIA could you please paste the details of ng version output here for debugging info?

from ng-dynamic-component.

Angular CLI: 12.2.16                                             
Node: 16.14.2 (Unsupported)                                      
Package Manager: npm 8.5.0                                       
OS: win32 x64                                                    
                                                                 
Angular: 12.2.16                                                 
... animations, cli, common, compiler, compiler-cli, core, forms 
... platform-browser, platform-browser-dynamic, router, upgrade  
                                                                 
Package                         Version                          
---------------------------------------------------------        
@angular-devkit/architect       0.1400.2                         
@angular-devkit/build-angular   12.2.16                          
@angular-devkit/core            12.2.16                          
@angular-devkit/schematics      14.0.2
@angular/cdk                    12.2.13
@schematics/angular             12.2.16
rxjs                            7.5.5
typescript                      4.3.5
webpack                         5.50.0

Warning: The current version of Node (16.14.2) is not supported by Angular.

from ng-dynamic-component.

Ok, from the response from Angular team it is not supported to use library compiled with newer angular in the app that is using older angular version.

This basically means that you either need to upgrade your app to angular v14 or disable peer dependencies check and keep using v9.

from ng-dynamic-component.

Yep, I just removed it from the latest release, thanks 😊

from ng-dynamic-component.