Option to disallow adding new and removing existing propertis to the observable about object-observer HOT 3 CLOSED

Hi,
I've just tried to actually do an Object.seal on observable and it works as expected, IMHO.
Specifically, if you'll run Object.seal on observable, then:

• no new properties may be added, TypeError thrown, as well as no existing properties may be deleted
• any existing properties are still subject to modification and any modification of those is correctly observed and notified to listeners

I've pushed a set of tests to cover those cases. You may review them in the tests/module/test-object-generics.js and notify me if I've missed anything.

If so - is it answering your case?

from object-observer.

Thank you! You are right, it does work as intended. I realized that our use case required deepSeal functionality. We wrote a deepSeal() function and then did deepSeal(observable) -- everything seems to be fine now. Perhaps, building this functionality (and having an option to use it) in the core of the library is still not such a bad idea.

Thank you again for you great work!

from object-observer.

Must say that my inclination is to keep the object-observer focused on it's own concern - observation, and not extend it with less specific and more object-utilities-like functionalities.

Anyway, glad it worked out well for you and thanks for the feedback!

from object-observer.