Decoupling SamplingJob from file format about ozz-animation HOT 2 CLOSED

Hi,

Thanks for reporting the issue. Very interesting !

With SkinningJob, the data provided is a bunch of spans + strides, meaning the file format I use is irrelevant.

Indeed that's the purpose of using spans for the skinning job. ozz doesn't fix the mesh format, as this is out of the library scope and difficult to make it engine agnostic.

Some cutscene animations call the stream read function 10,000 to 80,000 times for one animation

I was not expecting such an impact on animation reads. The changes to the animation formation done for the release 0.15.0 refactors serialization to use arrays. This significantly reduces the number of reads. Loading an animation with this version take tens of µs on an old laptop. Could you have a try ?

Also, just to be sure: are you using ozz::io::Stream provided by ozz, or have you implemented yours?

I'd like for the SamplingJob to receive its data as a set of spans like SkinningJob

It's impossible, constructing a runtime animation is complex, as you can see from the animation builder implementation, and not part of the public API. The public API from user perspective is that ozz will build a valid animation from a valid raw animation (which is easy to build).

and would like the SamplingJob::Context to allow me to provide it with data buffers

That's a good idea. Don't hesitate to provide a PR for this.
Also, have you considered recycling contexts?

Cheers,
Guillaume

from ozz-animation.

I consider this issue fixed with version 0.15.0 optimizations.

Don't hesitate to reopen if needed.

Cheers,
Guillaume

from ozz-animation.