Bug of LIST -a command! about minimalftp HOT 4 CLOSED

I have made a patch for you:
diff --git a/src/main/java/com/guichaguri/minimalftp/handler/FileHandler.java b/src/main/java/com/guichaguri/minimalftp/handler/FileHandler.java
index e22c079..50fc01f 100644
--- a/src/main/java/com/guichaguri/minimalftp/handler/FileHandler.java
+++ b/src/main/java/com/guichaguri/minimalftp/handler/FileHandler.java
@@ -233,7 +233,7 @@
// "-l" is not present in any specification, but chrome uses it
// TODO remove this when the bug gets fixed
// https://bugs.chromium.org/p/chromium/issues/detail?id=706905
- Object dir = args.length > 0 && !args[0].equals("-l") ? getFile(args[0]) : cwd;
+ Object dir = args.length > 0 && !args[0].equals("-l") && !args[0].equals("-a") ? getFile(args[0]) : cwd;

if(!fs.isDirectory(dir)) {
con.sendResponse(550, "Not a directory");
I can't push into your repository and I can't create a new branch and due to that I decided to write down it here.

from minimalftp.

Thanks for your contribution!

The -l parameter used to be added by Chromium by misinterpretation of the spec, that's why there is a condition to fix work around that. Is curlftpfs automatically adding the -a parameter to LIST?

Also, just a tip: You can fork the project, make your changes and then create a pull request instead of sending a raw patch.

from minimalftp.

Hi, we usually make merge requests at work. I didn't know about pull request. It's my first contribution at GitHub.
I used FileZilla to test it. And FileZilla added that parameter to LIST.
Then I tested it using curlftpfs as far as I remember and it also worked.

from minimalftp.

Fair enough, thank you for your contribution :)

from minimalftp.