Giter Club home page Giter Club logo

Comments (8)

ilija-lazoroski avatar ilija-lazoroski commented on June 28, 2024

extract-monkeyagentplugininterface.zip

This brings us to a somewhat working repo with passing UTs. We decided to abandon for now this as it depends on Utils.

from monkey.

mssalvatore avatar mssalvatore commented on June 28, 2024

extract-monkeyagentplugininterface.zip

This brings us to a somewhat working repo with passing UTs. We decided to abandon for now this as it depends on Utils.

Not abandon, just postpone.

from monkey.

ilija-lazoroski avatar ilija-lazoroski commented on June 28, 2024

Yep, poor choice of words.

from monkey.

shreyamalviya avatar shreyamalviya commented on June 28, 2024

extract-monkeyagentplugininterface.zip
This brings us to a somewhat working repo with passing UTs. We decided to abandon for now this as it depends on Utils.

Not abandon, just postpone.

Only until we extract the plugin utils repository?

from monkey.

mssalvatore avatar mssalvatore commented on June 28, 2024

Where sensible, this package should contain interfaces, not concrete implementations. For example, we may want to write an ITCPPortSelector interface for this package and leave the TCPPortSelector implementation in the agent.

from monkey.

ilija-lazoroski avatar ilija-lazoroski commented on June 28, 2024

extract-monkeyagentplugininterface.zip
This brings us to a somewhat working repo with passing UTs. We decided to abandon for now this as it depends on Utils.

Not abandon, just postpone.

Only until we extract the plugin utils repository?

Only until we do #3984

from monkey.

ilija-lazoroski avatar ilija-lazoroski commented on June 28, 2024

Where sensible, this package should contain interfaces, not concrete implementations. For example, we may want to write an ITCPPortSelector interface for this package and leave the TCPPortSelector implementation in the agent.

We need to do that in this issue?

from monkey.

mssalvatore avatar mssalvatore commented on June 28, 2024

Where sensible, this package should contain interfaces, not concrete implementations. For example, we may want to write an ITCPPortSelector interface for this package and leave the TCPPortSelector implementation in the agent.

We need to do that in this issue?

Might as well. Otherwise the agent/plugin interface would be improperly defined.

from monkey.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.