Feature request: better fg/bg contrast about colorv.vim HOT 5 OPEN

well , I'm using a simple algorithm to process faster for generating fb/bg.
maybe I should read the color_highlight's code to find how to improve it.

from colorv.vim.

By default, chrisbra/Colorizer just chooses black or white using

r*30 + g*59 + b*11 > 12000

(See ~ Colorizer/autoload/Colorizer.vim:1487).

I like ColorV's sophisticated coloring. But maybe ColorV can just have an option to choose black or white, for users who prefer maximum contrast.

from colorv.vim.

well, Don't have much time recently to get this small change..
any pull requests are welcome

from colorv.vim.

I made an implementation for s:prev_list() which functions similarly to Colorizer, with a threshold at 777777.

-        let hi_fg = b:view_area==1 ? hex : s:rlt_clr(hex)
+
+        if b:view_area == 1
+            let hi_fg = hex
+        elseif g:colorv_preview_bw
+            let [y,i,q]=colorv#hex2yiq(hex)
+            " y = 47 for #777777, which should be middle gray.
+            let hi_fg = (y < 47) ? "#ffffff" : "#000000"
+        else
+            let hi_fg = s:rlt_clr(hex)
+        endif

But after trying it more, I don't like it. It badly distorts my perception of brightness. For example, 737373 looks much brighter than 787878 and even AAAAAA because of the selection of a white fg for the darker background. To me, it is so bad I would not even merge the option. My opinion is not important, but I don't like the feature enough to put my name on the commit. So if somebody else wants it, they can use it or come up with another solution.

from colorv.vim.

Fine~
Anyway , it's nice of you to explore this.

from colorv.vim.