Giter Club home page Giter Club logo

Comments (3)

gtramontina avatar gtramontina commented on May 25, 2024

Perhaps there's a different way of asserting that the overwritten file has the correct permissions…? I can't recall why exactly that assertion is in place, to be honest. 🤔

from ooze.

Bios-Marcel avatar Bios-Marcel commented on May 25, 2024

Wouldn't calling FileMode be enough? I am a little confused as to what we need umask for?

from ooze.

Bios-Marcel avatar Bios-Marcel commented on May 25, 2024

I noticed that there are a couple more tests that don't really work on windows.

#19 also plays into this. When actually using hardlinks, we can't check for correct linkage anymore, as we can't necessarily detect whether we are a hardlink, since hardlinks are basically just normal files, unlike symlinks.

A workaround would be to manipulate the file and see whether both files change.

Additionally, some of the tests make assumptions on filepaths (different separators).

from ooze.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.