gtk::ImageBuilder::icon_size() should take a gtk::IconSize instead of i32 about gtk3-rs HOT 7 CLOSED

Indeed! Unfortunately the GObject property has the wrong type, so the autogenerated code is also wrong.

This would need some changes in gir to be able to opt-out of builders for specific properties. And then that specific property could be manually implemented. CC @EPashkin @antoyo

from gtk3-rs.

Why should it be a IconSize?
In GTK+, it is not.

from gtk3-rs.

Why should it be a IconSize?
In GTK+, it is not.

"Symbolic size to use for stock icon, icon set or named icon." says the docs. The symbolic size is exactly that, GtkIconSize :) The default value (4) is GTK_ICON_SIZE_BUTTON.

from gtk3-rs.

And it's a bug in GTK that it uses the wrong type for the property. Creating a MR for GTK4 now so it can at least be fixed there.

from gtk3-rs.

And it's a bug in GTK that it uses the wrong type for the property. Creating a MR for GTK4 now so it can at least be fixed there.

Already fixed there, good

from gtk3-rs.

So, is there anyting to fix in gir?
Or would it be fixed automatically with gtk4?

from gtk3-rs.

Will be fixed in gtk4, but would be nice to work around for gtk3.

from gtk3-rs.