Build of new SettingsSchemaKey API fails about gio HOT 17 CLOSED

You use feature v2_40 ?

from gio.

--all-features actually (to make sure none of my features are conflicting with each other and they all always compile). It happens when using gio with features = ["v2_38"] or earlier. v2_40 works fine as that will pull in the same feature from gio-sys.

The problem here is that the whole type is v2_40, but only its impl part is hidden behind that. The glib_wrapper! macro is not.

from gio.

You're never supposed to run --all-features. Maybe we should add a check to see if more than one version feature is enabled at once to make the compilation fail (we now have a compilation_fail!` macro so wy not using it?).

from gio.

Why make something fail that generally works unless you break things?

Also again, this breaks also if you just enable a pre-2.40 feature on gio. This does not need --all-features to fail.

from gio.

@sdroege Gio.SettingsSchemaKey don't have version in Gio-2.0.gir file,
so gir try detect it automatically by function, and some of function (g_settings_schema_key_get_description) have "2.34".
Can you try set version in config and check failure again.
Fix can be included in regen with gtk-rs/gir#498

from gio.

You mean

[[object]]
name = "Gio.SettingsSchemaKey"
status = "generate"
version = "2.40"

That has no effect

from gio.

Strange.
It don't change generated code?
cargo build --all-features on fixed gio works fine for me.
cargo build --features="v2_34" too.

from gio.

How does "fixed gio" look like? And yes, inside gio I also can't get it to fail for whatever reason. But create an empty new project with this in the Cargo.toml and it will fail: gio = { git = "https://github.com/gtk-rs/gio", features = ["v2_38"] }

from gio.

Key changes is

diff --git a/src/auto/mod.rs b/src/auto/mod.rs
index 8f4df03..fdf691c 100644
--- a/src/auto/mod.rs
+++ b/src/auto/mod.rs
@@ -1,4 +1,4 @@
-// This file was generated by gir (d50d839) from gir-files (469db10)
+// This file was generated by gir (83cd11e+) from gir-files (469db10)
 // DO NOT EDIT
 
 mod action;
@@ -101,9 +101,9 @@ pub use self::resource::Resource;
 mod settings_schema;
 pub use self::settings_schema::SettingsSchema;
 
-#[cfg(any(feature = "v2_34", feature = "dox"))]
+#[cfg(any(feature = "v2_40", feature = "dox"))]
 mod settings_schema_key;
-#[cfg(any(feature = "v2_34", feature = "dox"))]
+#[cfg(any(feature = "v2_40", feature = "dox"))]
 pub use self::settings_schema_key::SettingsSchemaKey;

Empty project with "v2_38" also builds fine for me.

from gio.

Yes that change would work

from gio.

Strange that you don't get it generated by #67 (comment)

from gio.

Well, let's merge this then and make my travis green again? :)

from gio.

This? I don't see any PR for gio.

from gio.

I thought you submitted one :)

from gio.

No, I still waiting your PR's with gtk-rs/gir#498.
so I though that you can add this change to gio's.

from gio.

Not really important to do regens for that one, and as I wrote above the change in the .toml file does not work for me while it does for you. I must be adding something wrong to the .toml file.

from gio.

IMHO any update that change many files in many crates better applied fast to simplify check future updates.
#67 (comment) is look right change for me,
may be you forgot to remove "Gio.SettingsSchemaKey" from generate array and gir just don't do anything.

from gio.