Giter Club home page Giter Club logo

Comments (4)

gskinner avatar gskinner commented on August 24, 2024

Good catch. This should be an easy fix, I'll look into it (probably today).

from flutter_animate.

gskinner avatar gskinner commented on August 24, 2024

Ok. Dug into this a bit, and it's not as easy a fix as I first thought, unless we just catch the error and call it good enough (which isn't necessarily a terrible option).

I think the way I'd like to approach this is reverse the control flow by changing Adapter into a notifier, which Animate subscribes to, and then it can unsubscribe on dispose. This should also allow for adapters to be shared between Animate instances, which might be useful on occasion.

May as well also add Adapter.enabled while I'm at it.

from flutter_animate.

gskinner avatar gskinner commented on August 24, 2024

I just pushed a fix for this. I would really appreciate if you're able to test against this fix to confirm it's resolved in your example @indmind

from flutter_animate.

tioirawan avatar tioirawan commented on August 24, 2024

Sorry for the late reply, I have tested the fix for the issue with using ScrollAdapter inside of a ListView, and I am happy to report that it is working as expected. Thank you, I appreciate your efforts in resolving the issue.

from flutter_animate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.