Comments (8)
I'm pretty sure the directory names with apostrophes and the like are handled fine in Jump's JSON database, however, these could be a problem in the shell integrations. What shell are you using?
from jump.
I'm using bash -- but I found out something more about what's the issue here. Jumping to directories with hyphens does actually work when I don't tab-complete the target directory. So if I just type "j search" I do land at the right target even if a parent directory has hyphens. I'd gotten used to tab completing the searches in order to see the full path, and when I do that it doesn't work. I just tested with zsh but I've probably not got it set up right because tab completion didn't do anything there. Completion without tab worked with hyphens in zsh too as for bash.
So I guess the question is if jumping to a directory after tab completion a feature in jump or something bash specific?
from jump.
It could be the missing escaping when generating the completion hints. Can you try changing this line to:
Line 17 in cedde1e
jump hint "$term"
You don't need to compile jump, but replace the integration in you bashrc from eval "$(jump shell bash)"
to the bash script lines inside of the ` block.
from jump.
My .bashrc contained the lines
eval "$(jump shell)"
(from the front page instructions)
When I first tried to change this to
eval "$(jump shell bash)"
I got the same behavior as before.
Further changing this line to
eval "$(jump hint $term)"
does not evaluate well, and I get an error when starting bash. Perhaps I didn't write what you intended?
from jump.
I'll test it locally and put a build for you to test as well. It will be easier than writing the integration script manually.
from jump.
I have tested it locally and have a fix for this. Will release a new version of Jump tomorrow with it.
from jump.
Thanks! Will test when out :)
from jump.
Thank you for bringing this up! This was a security issue as well. If a cleverly named directory existed in you jump database, going to the directory by following the autocompletion could have been dangerous! You can spawn shell commands with the directory name and that's not good. Again, thanks for the notice.
The autocompletion should be fixed for such cases in the new release, 0.40.0
. Read the release notes for more details. I have attached a jump_osx
OSX binary, because it will take a while for brew to pick up the new release.
from jump.
Related Issues (20)
- RPM refuses to install on Fedora due to OS is specified as darwin HOT 4
- jump has stopped tracking my directories HOT 4
- RangerFM integration HOT 2
- Integration documentation outdated? HOT 6
- Add option to use pushd instead of cd in dir motion HOT 1
- [MacOS] brew installs Jump Desktop instead of this tool HOT 2
- `jump import` does not work for non-default Z_DATA location. HOT 2
- brew install jump HOT 1
- jump 0.41.0 debian packages are broken HOT 3
- Release the binary of jump v0.41.0 for macOS HOT 5
- windows builds HOT 6
- Release assets of jump v0.50.0 for Linux HOT 3
- v0.51.0 - release binaries request HOT 2
- ARM version in brew HOT 3
- command not found: jump HOT 2
- Flatpak Install Option HOT 2
- Consider adding an ability to create aliases within jump HOT 3
- Move differences documentation into readme HOT 1
- How to setup database on Windows 10? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jump.