Giter Club home page Giter Club logo

Comments (4)

dfawley avatar dfawley commented on July 23, 2024 1

@apolcyn noticed that if we simply changed the locality ID to use the first address instead of the last, we'd most likely improve the accuracy (since the first address is more likely to be connected to than the last):

http://google3/third_party/golang/grpc/xds/internal/balancer/clusterimpl/clusterimpl.go;l=364;rcl=634425291

from grpc-go.

neilw4 avatar neilw4 commented on July 23, 2024 1

Please do not change the locality ID to always use the first address. Reported load needs to be 100% accurate, especially in cases where we're failing over to different backends.

from grpc-go.

dfawley avatar dfawley commented on July 23, 2024

The above comment was suggested as a short-term workaround that would take a few minutes to accomplish while we await the full fix.

from grpc-go.

dfawley avatar dfawley commented on July 23, 2024

Another idea for a short-term fix that will actually get us to 100% correctness but not take as long to implement (hopefully):

  1. Add an unexported field to balancer.SubConnState that, when the ConnectivityState is READY, contains the connected address.
  2. Add accessor function vars for this field in internal which the balancer package assigns to local functions that perform the actions.
  3. Set this in the channel around here, indirectly.
  4. Read this in the StateListener (here) and call updateLocalityID() based on the connected address's locality.
  5. Add a test to verify.

This works better than adding an unexported method to the SubConn, because the subconn wrapping requires propagating the method everywhere.

from grpc-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.