Rate Limit Interceptor about go-grpc-middleware HOT 9 CLOSED

This looks to be a good library that would be useful for doing this https://github.com/juju/ratelimit

from go-grpc-middleware.

@vtolstov Yep. I have written some codes about this issue. I will probably submit a PR in this week(Wednesday or Thursday).

from go-grpc-middleware.

Hey @fifthaxe ,

Thanks for the suggestion, some protection from a problem clients is a great idea.

Having a RateLimit interceptor would be a better idea however the implementation would not want to sleep the incoming calls on the server we would just want to reject the calls if a user has hit the rate limit.
Thinking along the lines that if a client made n requests in a time window (both configurable) we would start to do the equivalent of HTTP 429.
Please feel free to put out a Work In Progress PR for this and we can talk through the implementation when we have something more.

Dom

from go-grpc-middleware.

Sounds like we need a dummy net pipe restriction like features, that would be a great gRPC enhancement (QoS, filtering, rate limiting, latency control ...).

from go-grpc-middleware.

any steps to get such interceptor?

from go-grpc-middleware.

Have not seen any PRs from @fifthaxe so @vtolstov feel free to pick up 😄

from go-grpc-middleware.

I would like to take that. Can you assign this issue to me? @domgreen @mwitkow

from go-grpc-middleware.

Amazing @fengzixu thats great to hear 👍 I can't currently assign you but put a PR out and we will link it here.

from go-grpc-middleware.

@fengzixu do you have time to create pr?

from go-grpc-middleware.