Improve docs around grpc_zap.WithDecider about go-grpc-middleware HOT 5 CLOSED

The WithDecider is only useful for Payload* interception and logging. We should improve docs here.

from go-grpc-middleware.

Wouldn't it be still useful to be able to call a decider on normal logging regardless? On the server side as I was saying there are no "finished call" logging messages on filtered events because UnaryServerInterceptor calls shouldLog before the "finished call" message. This was added later via #113 in server_interceptors.go.

Given the two functions UnaryServerInterceptor and UnaryClientInterceptor are fairly similar I figured the enhancement that was merged on the server side could be applicable on the client side as well. Of course I might be misunderstanding the intent, so will be looking for the doc changes to clarify, thanks!

from go-grpc-middleware.

@domgreen can you please weigh in, as you authored the #113 change?

from go-grpc-middleware.

hi, i'm working on a grpc proxy stuff, using both server and client side interceptor. and i find that client side decider is useful, since i only want to log suspicious non-ok request.

i also think it's good idea to keep an consistent semantics as possible. isn't it?

from go-grpc-middleware.

This is pretty old and we know have v2 code with different structure. Let us know if this is still important, we can reopen.

from go-grpc-middleware.