Comments (16)
both have the same purpose : set a stop_time for the last stop of the trip.
Maybe that's a reason to unify both properties into one?
from osm2gtfs.
This is a good idea. I think you could apply the same logic to the Line object and keep all tags.
from osm2gtfs.
Here is my guess
- travel_time is read from an OSM tag whereas duration is set from another source.
- travel_time is an number of minutes whereas duration is a timedelta.
But beside that, I think they both have the same purpose : set a stop_time for the last stop of the trip.
from osm2gtfs.
I know you don't care how data is structure within OSM, but travel_time
is more often used in combination with public_transport:version
than duration
. 😉
from osm2gtfs.
Wohoo nice new photo @jamescr! 😎
I'd be fine consolidating things to travel_time
. We would just need to harmonize the data type across the creators.
from osm2gtfs.
Wohoo nice new photo @jamescr! 😎
Thanks
from osm2gtfs.
Yes, indeed very nice photo, @jamescr! You look a bit different, than the last time I saw you :)
The OpenStreetMap terminology clearly seems to prefer duration
:
- https://wiki.openstreetmap.org/wiki/Key:duration
- https://wiki.openstreetmap.org/wiki/Tag:route%3Dbus
Not even one mention of travel_time
in the wiki.
from osm2gtfs.
Yes, indeed very nice photo, @jamescr! You look a bit different, than the last time I saw you :)
Thanks, I'm getting old ;-)
The OpenStreetMap terminology clearly seems to prefer duration:
I did wrong a search on the wiki here and there.
Thanks for the correction, is really nice to have you back collaborating.
from osm2gtfs.
Working on the data structre (#30) I see that travel_time
has been introduced by @nlehuby. Are you using this for tags on the OSM data for Accra? Or can this be changed easily to duration
, according to the specs of OpenStreetMap?
from osm2gtfs.
There is travel_time
on one wiki page. However, this seems to be wrong, as those aren't part of any approved proposal. I asked for verification on the respective mailing list.
from osm2gtfs.
Accra OSM mappers use the travel_time
tag for the time (in min) to travel from the first to the last stop. See https://wiki.openstreetmap.org/wiki/AccraMobile3#Tro_tro_lines
The duration
is not part either of an approved proposal...
Do you want to create a proposal for that purpose ?
from osm2gtfs.
Isn't the tag duration already official?
from osm2gtfs.
from osm2gtfs.
I propose to do the following (within #96):
- Give the
Itinerary
the whole set of tags from OSM'sroute
, so these can be used in the creators. - Make
duration
a standard, but optional attribute toItinerary
- Alter
trips_creator_accra
to use thetravel_time
tag fromItinerary.tags
This would extend the script to be more powerful, because all tags can potentially used in the creators; it also allows Accra to continue working with their current data; and it encourages use of duration
(community's consensus).
It is implemented in this commit. Please check, if this is ok for you all. Thanks!
from osm2gtfs.
Applied to PR #96. This also is related to #13.
from osm2gtfs.
Resolved with accepted PR #99
from osm2gtfs.
Related Issues (20)
- Add city name to stop HOT 18
- Add city information to Line/Itinieray names HOT 3
- Support multiple values for the same OSM tag HOT 1
- Extend handling of `start_date`/`end_date` to support schedule as a source HOT 5
- Support all possible values of service periods and exceptions HOT 6
- Add alternative schedule source format with frequencies HOT 2
- Core tests HOT 2
- Implement included_lines and excluded_lines in standard trip creator or OsmConnector HOT 7
- Enabling a fast simple creator without timetable HOT 3
- Search for alternative stop name in the stop_area relation if exists before searching for other nodes close to the stop
- Default implementation for TripCreator with frequency support HOT 5
- Handle ref duplicates HOT 5
- Cache based on config file, not selector to support different agencies per city HOT 4
- Support hail_and_ride / GTFS Flex HOT 16
- [question] Potential stop is invalid and has been ignored / nodes of a platform way HOT 3
- Incomplete shapes because of roundabout HOT 1
- Issues loading bus stops HOT 2
- problem with package installation
- problem with package installation HOT 1
- "This feed has no effective service dates!" Error HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from osm2gtfs.