Comments (13)
Strange that it doesn't tell you to walk from stop A2 to stop A4.
But in general, I agree that we should have support for parent_stations and stop_area relations.
Your dataset should be sufficiently small to add the parent station manually and see if that helps with the problem. Maybe it is worth a try.
from osm2gtfs.
With the stops grouped in a station Transportr tell me to walk from stop A2 and A4, and the results make more sense. Here are the results, image at 2:43pm is without station and image at 2:40pm is with station.
from osm2gtfs.
Thanks for the screenshots. Looks good. If you want to work on this, maybe let's merge your incofer branch first. It seems to be in a usable state already.
from osm2gtfs.
Sure I'll work on this issue.
You mean the incofer branch of public-transport-enabler and Transportr ?
from osm2gtfs.
Sure I'll work on this issue.
Awesome! :)
You mean the incofer branch of public-transport-enabler and Transportr ?
No, I meant the incofer provider for osm2gtfs.
from osm2gtfs.
Honestly I wasn't expecting to merge it, but if you agree I think it's great!.
from osm2gtfs.
In my opinion, all other creators should ideally be merged here. This makes sense for example when we refactor the code. If the creators live in other repositories, they need to be manually adjusted to whatever changed in the upstream repository.
from osm2gtfs.
I have a working draft for this issue: https://github.com/jamescr/osm2gtfs/tree/issue-55. Now It's only working for Incofer but I'll appreciate any comment before extending it to fenix. By the way i have one doubts about stop/stop_areas, a OSM stop/platform could be member of more than one stop_area?
from osm2gtfs.
Great! :)
Just gave it a quick look and I wonder whether it is necessary to make an extra query per stop_area. Couldn't this data be returned by @xamanu's new optimized query?
from osm2gtfs.
The problem with the stop_area is that those aren't part of the relations that describe a route. Stops and platforms are part of a stop_area relation. Anyway I'll look at @xamanu query to be sure if I could reused it.
from osm2gtfs.
I have implemented an alternative solution that uses the _query_stops() with a little modification to get the stop_areas. Also includes a different approach on handling stops (similar in some way to the routes variants and masters). Again I have been testing with incofer but this is only a request for comments draft.
from osm2gtfs.
Nice! I didn't review it, but looks like with this solution, you don't need to make additional queries. Great!
Do you personally prefer this solution over the other one?
from osm2gtfs.
Yes I think the alternative solution is better. I hope I could finish it by the end of the week.
from osm2gtfs.
Related Issues (20)
- Add city name to stop HOT 18
- Add city information to Line/Itinieray names HOT 3
- Support multiple values for the same OSM tag HOT 1
- Extend handling of `start_date`/`end_date` to support schedule as a source HOT 5
- Support all possible values of service periods and exceptions HOT 6
- Add alternative schedule source format with frequencies HOT 2
- Core tests HOT 2
- Implement included_lines and excluded_lines in standard trip creator or OsmConnector HOT 7
- Enabling a fast simple creator without timetable HOT 3
- Search for alternative stop name in the stop_area relation if exists before searching for other nodes close to the stop
- Default implementation for TripCreator with frequency support HOT 5
- Handle ref duplicates HOT 5
- Cache based on config file, not selector to support different agencies per city HOT 4
- Support hail_and_ride / GTFS Flex HOT 16
- [question] Potential stop is invalid and has been ignored / nodes of a platform way HOT 3
- Incomplete shapes because of roundabout HOT 1
- Issues loading bus stops HOT 2
- problem with package installation
- problem with package installation HOT 1
- "This feed has no effective service dates!" Error HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from osm2gtfs.