Giter Club home page Giter Club logo

Comments (13)

grote avatar grote commented on May 26, 2024

Strange that it doesn't tell you to walk from stop A2 to stop A4.

But in general, I agree that we should have support for parent_stations and stop_area relations.

Your dataset should be sufficiently small to add the parent station manually and see if that helps with the problem. Maybe it is worth a try.

from osm2gtfs.

jamescr avatar jamescr commented on May 26, 2024

With the stops grouped in a station Transportr tell me to walk from stop A2 and A4, and the results make more sense. Here are the results, image at 2:43pm is without station and image at 2:40pm is with station.

photo_2017-02-10_14-42-34

photo_2017-02-10_14-42-43

from osm2gtfs.

grote avatar grote commented on May 26, 2024

Thanks for the screenshots. Looks good. If you want to work on this, maybe let's merge your incofer branch first. It seems to be in a usable state already.

from osm2gtfs.

jamescr avatar jamescr commented on May 26, 2024

Sure I'll work on this issue.

You mean the incofer branch of public-transport-enabler and Transportr ?

from osm2gtfs.

grote avatar grote commented on May 26, 2024

Sure I'll work on this issue.

Awesome! :)

You mean the incofer branch of public-transport-enabler and Transportr ?

No, I meant the incofer provider for osm2gtfs.

from osm2gtfs.

jamescr avatar jamescr commented on May 26, 2024

Honestly I wasn't expecting to merge it, but if you agree I think it's great!.

from osm2gtfs.

grote avatar grote commented on May 26, 2024

In my opinion, all other creators should ideally be merged here. This makes sense for example when we refactor the code. If the creators live in other repositories, they need to be manually adjusted to whatever changed in the upstream repository.

from osm2gtfs.

jamescr avatar jamescr commented on May 26, 2024

I have a working draft for this issue: https://github.com/jamescr/osm2gtfs/tree/issue-55. Now It's only working for Incofer but I'll appreciate any comment before extending it to fenix. By the way i have one doubts about stop/stop_areas, a OSM stop/platform could be member of more than one stop_area?

from osm2gtfs.

grote avatar grote commented on May 26, 2024

Great! :)

Just gave it a quick look and I wonder whether it is necessary to make an extra query per stop_area. Couldn't this data be returned by @xamanu's new optimized query?

from osm2gtfs.

jamescr avatar jamescr commented on May 26, 2024

The problem with the stop_area is that those aren't part of the relations that describe a route. Stops and platforms are part of a stop_area relation. Anyway I'll look at @xamanu query to be sure if I could reused it.

from osm2gtfs.

jamescr avatar jamescr commented on May 26, 2024

I have implemented an alternative solution that uses the _query_stops() with a little modification to get the stop_areas. Also includes a different approach on handling stops (similar in some way to the routes variants and masters). Again I have been testing with incofer but this is only a request for comments draft.

from osm2gtfs.

grote avatar grote commented on May 26, 2024

Nice! I didn't review it, but looks like with this solution, you don't need to make additional queries. Great!
Do you personally prefer this solution over the other one?

from osm2gtfs.

jamescr avatar jamescr commented on May 26, 2024

Yes I think the alternative solution is better. I hope I could finish it by the end of the week.

from osm2gtfs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.