Giter Club home page Giter Club logo

Comments (5)

xamanu avatar xamanu commented on May 23, 2024

Cool. This would be great support in preparation of #30.

from osm2gtfs.

xamanu avatar xamanu commented on May 23, 2024

After pull request #43 I see almost all functions in Stop, Route, RouteMaster and BaseRoute to be Fenix specific.

Only those one's aren't Fenix specific:

Stop.get_center_of_nodes()
Route.print_shape_for_leaflet()

And probably we want to implement one more generic function like:

Route.get_stop_by_position(int) instead of Route.get_first_stop()

from osm2gtfs.

xamanu avatar xamanu commented on May 23, 2024

After pull request #44 (Default implementation for stops creation): If TripsCreatorFenix logic implemented pulling Stop objects from data.stops based on the stop ids in Route.stops, then Fenix could use the default StopsCreator implementation and get rid of the StopsCreatorFenix 👍

from osm2gtfs.

grote avatar grote commented on May 23, 2024

Route.print_shape_for_leaflet()

This one is actually just a debugging function that I used during development. You can show the route on a leaflet map and inspect it in detail. Do you think we should keep this?

And probably we want to implement one more generic function like:

Route.get_stop_by_position(int) instead of Route.get_first_stop()

Yup, that's fine with me. Would be a fairly small pull request.

from osm2gtfs.

xamanu avatar xamanu commented on May 23, 2024

Route.print_shape_for_leaflet()

This one is actually just a debugging function that I used during development. You can show the route on a leaflet map and inspect it in detail. Do you think we should keep this?

I actually was thinking about creating a Debug class for this and more debug functionality. Here is a separate issue for this: #46

from osm2gtfs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.