Giter Club home page Giter Club logo

Comments (11)

grosser avatar grosser commented on September 25, 2024

yep, also ran into this problem quiet often :)
i think it would be good to have this double-piping-magic, maybe a fallback could be added to get the old behavior, in case someone really needs 'one process per item'.

from parallel.

grosser avatar grosser commented on September 25, 2024

can you try to merge/add it, or should i give it a try ?

from parallel.

ngauthier avatar ngauthier commented on September 25, 2024

I can definitely merge it in. It may be a while before I get a chance to do it.

-Nick

from parallel.

grosser avatar grosser commented on September 25, 2024

Great, made myself an reminder to do it in 1 week, hope you can beat me :)

from parallel.

grosser avatar grosser commented on September 25, 2024

any progress ?

from parallel.

ngauthier avatar ngauthier commented on September 25, 2024

nope sorry. :-(

from parallel.

grosser avatar grosser commented on September 25, 2024

then ill give it a try tomorrow, already had a close look at the code :>

from parallel.

grosser avatar grosser commented on September 25, 2024

im finished so far (its on the 'worker' branch)
only thing i do not understand:

  • why rescue from Interrupt, when does it happen / why is it bad ?
  • why wait for the processes after the threads are joined, the processes should have finished by then / can be killed

from parallel.

ngauthier avatar ngauthier commented on September 25, 2024

rescue from interrupt so that if you have 10 parallel processes, and one blows up, you don't get multiple stack traces. It's easier to debug forking issues this way. Not necessary, just helpful.

You have to either wait or detach a process or it could go zombie on you. This is very important if someone is using parallel in a long running process, like rails. The thread could have joined because the pipe broke, but the process could keep going. Believe me, you want it to hang on wait when something goes wrong, not just keep going. You could replace wait with kill if you want, but I think wait is better. Definitely don't detach. That could get crazy.

from parallel.

grosser avatar grosser commented on September 25, 2024

fixed in 0.5.0

from parallel.

ngauthier avatar ngauthier commented on September 25, 2024

Very cool. I'd like to try this out with parallel_tests, to see if it improves testing performance.

EDIT: never mind. I see you shell out in groups so it probably won't do too much in that case.

from parallel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.