Giter Club home page Giter Club logo

Comments (5)

berrnd avatar berrnd commented on July 18, 2024 1

Here's a reproduced example on the public Demo server.
Link: https://test-g4r0azghrcbs4zjhijsl.demo-prerelease.grocy.info/userobjects/test

All your defined Userentity fields (=> https://test-g4r0azghrcbs4zjhijsl.demo-prerelease.grocy.info/userfields?entity=userentity-test) don't have the option Show as column in tables checked. Without that much surprise, no single field defined by you to be shown in a table = no field shown in a table. When properly defining that, everything works as you expect it - and I already did that on your provided persistent demo instance. By a bit more extensive comparison with the default demo, it's pretty easy to find such things out yourself.

According to README the better place for general usage questions is the r/grocy subreddit - please use that place if you're unsure how stuff is supposed to work instead of digging into random HTML, seeing bugs were no one is.

from grocy.

QazCetelic avatar QazCetelic commented on July 18, 2024

The class is indeed supposed to be removed here. This part of the code also hasn't been changed in 5 years.

from grocy.

berrnd avatar berrnd commented on July 18, 2024

I looked at the HTML and it turned out that the user entity table body has the d-none (aka display none / hide) tag. It seems to be hardcoded into the Blade template 5 years ago, I assume the tag is supposed to be removed somewhere else.

The class is indeed supposed to be removed here.

Bullshit. If you look at a web application like Grocy, the server side rendered HTML markup is one thing, all the client side JavaScript the other thing. So adding d-none here doesn't lead to an invisible table when just a handful of milliseconds later the exact same tag is removed (code ref, it's about DataTables initial rendering performance optimization - a invisible DOM sourced table renders faster - and happens exactly like so for each and every table throughout Grocy).

The issue template explicitly mentions to test stuff on the pre-release demo beforehand - it works there: https://demo-prerelease.grocy.info/userobjects/exampleuserentity

Otherwise please provide a 100 % reproducible example (also mentioned at the same issue template), something that does only not work on your end is just like always not a bug.

 

This part of the code also hasn't been changed in 5 years.

Well, I guess there are other couple of thousands lines that haven't changed either in the same amount of time - what should that mean exactly and how is it relevant for anything how often a single line of code changes?

from grocy.

QazCetelic avatar QazCetelic commented on July 18, 2024

Bullshit. If you look at a web application like Grocy, the server side rendered HTML markup is one thing, all the client side JavaScript the other thing. So adding d-none here doesn't lead to an invisible table when just a handful of milliseconds later the exact same tag is removed (code ref, it's about DataTables initial rendering performance optimization - a invisible DOM sourced table renders faster - and happens exactly like so for each and every table throughout Grocy).

I'm aware that the prerenderd HTML is supposed to be changed by the client JavaScript on the line I also linked to, but it isn't.

Here's a reproduced example on the public Demo server.
Link: https://test-g4r0azghrcbs4zjhijsl.demo-prerelease.grocy.info/userobjects/test
image

Well, I guess there are other couple of thousands lines that haven't changed either in the same amount of time - what should that mean exactly and how is it relevant for anything how often a single line of code changes?

Just checking if there was a recent change that could cause a regression.

from grocy.

QazCetelic avatar QazCetelic commented on July 18, 2024

That explains a lot, I seem to have missed the option completely. Thanks for taking your time to explain. I will make sure to go to the subreddit instead next time.

from grocy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.