Giter Club home page Giter Club logo

Comments (3)

berrnd avatar berrnd commented on June 11, 2024

Expected behavior
The default shopping list (with id 1) is selected.

That's fine that you expected that, but how is something you personally expect supposed to be a Bug?

I'm open to improve or change stuff and that's what naturally a Feature Request is for, but allergic to when each and every little detail is reported as a Bug.

from grocy.

mawwinius avatar mawwinius commented on June 11, 2024

Okay, that answers the question which of these two types I should have chosen. Honestly, I was unsure, and would like to apologize for mis-categorizing this one. Thank you for changing the label accordingly.

Do you agree with my opinion on the expected behavior? And if yes, would you be interested in a Pull Request implementing my suggestion?

from grocy.

berrnd avatar berrnd commented on June 11, 2024

Do you agree with my opinion on the expected behavior?

Doesn't sound not right at a first sight, but I don't think each and every request to the very end before working on it.

 

And if yes, would you be interested in a Pull Request implementing my suggestion?

Feel free to do whatever you want. In any case, please make sure to not only have your specific workflow in mind - test stuff you change thoroughly. Grocy e.g. has a Feature Flag FEATURE_FLAG_SHOPPINGLIST_MULTIPLE_LISTS which most likely has to be taken into account for this - just saying that due to I had it multiple times in the past where even such rather simple changes introduced kind of triple the time needed to review it, than simply doing it myself.

from grocy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.