Comments (2)
It appears that the form (and underlying API) do in fact allow submission of a Predictive EID without a drug. It is also not marked as required (with a *
) in the form help text.
Seems like an implementation mistake - we should be able to make at least one drug required going forward for predictive EIDs!
from civic-client.
@jmcmichael I added
expressionProperties: {
'templateOptions.required': function ($viewValue, $modelValue, scope) {
return scope.model.evidence_type === 'Predictive';
}
To the drugs form field which "works" in the sense that it now puts the *
required annotation, but it doesn't seem to actually enforce the behavior. You can still submit without specifying a drug (even if you manually delete the empty row). AM I missing somewhere else this needs to be set? Or is it an issue with array types that I need to deal with in the controller or something?
from civic-client.
Related Issues (20)
- Comment not needed to submit revision to Variants, Variant Groups, Genes
- @ mention in EID Additional Comments not working HOT 1
- When a source is from ASCO, the journal is being resolved incorrectly HOT 1
- Create job to push monthly data dumps to AWS open data S3 bucket
- Include flag status in data releases
- Unable to add variant group HOT 1
- Make display of N/A consistent
- HPO tooltip update HOT 1
- Editing variant groups error HOT 2
- CIViC organization statistics colors are wrong HOT 1
- Source suggestion queue isn't accepting non-existing variants HOT 1
- Internal server error in the civic api HOT 1
- OpenCRAVAT integration HOT 1
- Browse grid pages showing same EIDs more than once HOT 1
- Additional sources / visualizations should be investigated from Genome Nexus HOT 1
- Register CIViC Entity Prefixes HOT 12
- Incorrect gene_id in request https://civicdb.org/api/variants HOT 1
- CIViC bot task to update fusion names to use new delimiter convention HOT 2
- Add links from individual variants to the Evidence Repo
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from civic-client.