Giter Club home page Giter Club logo

Comments (9)

fscheiner avatar fscheiner commented on September 3, 2024

Thanks for the pointer.

But I wonder why it doesn't work for your OpenSSL version 3.1.4. Because considering that openssh/openssh-portable@f6d3ed9 enables version 3.2.x and openssh/openssh-portable@3e21d58 enables 3.3.x, 301 should enable 3.1.x if I'm not mistaken.

And 301* should at least match the first part of 30100040 (OpenSSL 3.1.4 24 Oct 2023).

from gct.

msalle avatar msalle commented on September 3, 2024

but the commit adds just the 300 and 301 as unsupported versions. Also the one before, from 2 years ago, adds 300 as unsupported version.
That's different from this commit in the upstream patches.

from gct.

fscheiner avatar fscheiner commented on September 3, 2024

@msalle

but the commit adds just the 300 and 301 as unsupported versions. Also the one before, from 2 years ago, adds 300 as unsupported version.

No, I think there is no fall-through to the unsupported *) case. If there was, all cases would fall-through instead of ending at the ;;.

from gct.

msalle avatar msalle commented on September 3, 2024

ah right indeed, sorry shouldn't have looked on my phone.

The problem is that the configure.ac in gct-6.2.1653033972/gsi_openssh/source is an old one. I just noticed that the configure and configure.ac in there only support up to 3.0.X.
Also the current draft release still points to that version of Jun 8, 2022. The 301 support dates back to Feb 21 (see f60262d)

from gct.

fscheiner avatar fscheiner commented on September 3, 2024

ah right indeed, sorry shouldn't have looked on my phone.

I made the same error at first, because it just looks like so.

The problem is that the configure.ac in gct-6.2.1653033972/gsi_openssh/source is an old one. I just noticed that the configure and configure.ac in there only support up to 3.0.X.

Now I understand the problem. I didn't notice that issue as the OP quoted from current code state - where it looks and is OK IIUC - but used the last release tarball when trying to build the package on AUR, which is pre 2022-05-24.

Also the current draft release still points to that version of Jun 8, 2022. The 301 support dates back to Feb 21 (see f60262d)

Yes, I haven't yet updated the draft release since copying the content from the last release.

from gct.

fscheiner avatar fscheiner commented on September 3, 2024

@ickc: This issue will hence be solved with the next GCT release that will materialize before end of this year.

from gct.

ickc avatar ickc commented on September 3, 2024

Thanks all. I guess it should be closed now.

from gct.

fscheiner avatar fscheiner commented on September 3, 2024

Oh, we usually keep issues open until there's a release that fixes them.

from gct.

ickc avatar ickc commented on September 3, 2024

Ok, sure. Thanks again! Sorry for not having time to look into it again and providing more details, but you all figured it out already.

from gct.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.