Frontend should check table exists before creating a table about greptimedb HOT 5 CLOSED

How about having a try with gtctl

I tried it and playground in greptimecloud, but create table was successfully created. (playground in greptimecloud has 3 regions.) Am I missing something?

Reproduction

CREATE TABLE test_table (
    a INT PRIMARY KEY,
    ts TIMESTAMP TIME INDEX
) PARTITION BY RANGE COLUMNS(a) (
    PARTITION r0 VALUES LESS THAN (10),
    PARTITION r1 VALUES LESS THAN (20),
    PARTITION r2 VALUES LESS THAN (MAXVALUE),
);

Then

CREATE TABLE if not exists test_table (
    a INT PRIMARY KEY,
    ts TIMESTAMP TIME INDEX
) PARTITION BY RANGE COLUMNS(a) (
    PARTITION r0 VALUES LESS THAN (10),
    PARTITION r1 VALUES LESS THAN (20),
    PARTITION r2 VALUES LESS THAN (MAXVALUE),
);

Link

https://greptime.com/product/cloud

Hi @NiwakaDev , Thank you for your report. The cloud service may not use the latest version. I'll double-check it later.

from greptimedb.

I'd like to address this issue, but I don't know how to make a test which can reproduce it.

I tried to reproduce this issue, like so:

    #[tokio::test(flavor = "multi_thread")]
    async fn test_issue2128() {
        common_telemetry::init_default_ut_logging();

        let instance =
            tests::create_distributed_instance("test_distributed_insert_delete_and_query").await;
        let frontend = instance.frontend();
        let frontend = frontend.as_ref();

        let table_name = "my_dist_table";
        let sql = format!(
            r"
CREATE TABLE {table_name} (
    a INT,
    ts TIMESTAMP,
    TIME INDEX (ts)
) PARTITION BY RANGE COLUMNS(a) (
    PARTITION r0 VALUES LESS THAN (10),
    PARTITION r1 VALUES LESS THAN (20),
    PARTITION r2 VALUES LESS THAN (50),
    PARTITION r3 VALUES LESS THAN (MAXVALUE),
)"
        );
        create_table(frontend, sql).await;
        let sql = format!(
            r"
CREATE TABLE if not exists {table_name} (
    a INT,
    ts TIMESTAMP,
    TIME INDEX (ts)
) PARTITION BY RANGE COLUMNS(a) (
    PARTITION r0 VALUES LESS THAN (10),
    PARTITION r1 VALUES LESS THAN (20),
    PARTITION r2 VALUES LESS THAN (50),
    PARTITION r3 VALUES LESS THAN (MAXVALUE),
)"
        );
        create_table(frontend, sql).await;

    //

And then I executed cargo nextest run test_issue2128
But, the above test seems to pass.

from greptimedb.

How about having a try with gtctl

from greptimedb.

How about having a try with gtctl

I tried it and playground in greptimecloud, but create table was successfully created. (playground in greptimecloud has 3 regions.) Am I missing something?

Reproduction

CREATE TABLE test_table (
    a INT PRIMARY KEY,
    ts TIMESTAMP TIME INDEX
) PARTITION BY RANGE COLUMNS(a) (
    PARTITION r0 VALUES LESS THAN (10),
    PARTITION r1 VALUES LESS THAN (20),
    PARTITION r2 VALUES LESS THAN (MAXVALUE),
);

Then

CREATE TABLE if not exists test_table (
    a INT PRIMARY KEY,
    ts TIMESTAMP TIME INDEX
) PARTITION BY RANGE COLUMNS(a) (
    PARTITION r0 VALUES LESS THAN (10),
    PARTITION r1 VALUES LESS THAN (20),
    PARTITION r2 VALUES LESS THAN (MAXVALUE),
);

Link

https://greptime.com/product/cloud

from greptimedb.

Verified, it's gone in v0.4

from greptimedb.