Comments (1)
I agree this is a bit confusing and me and my fellow engineers have been tripping over this too.
For what it's worth, here's what we do:
First, register WinstonLogger as the Nest application logger:
import { WinstonModule } from 'nest-winston';
async function bootstrap() {
const app = await NestFactory.create(AppModule, {
logger: WinstonModule.createLogger({
// options (same as WinstonModule.forRoot() options)
})
});
await app.listen(3000);
}
bootstrap();
Then, in the class, manually create an instance of NestJS Logger
(not WinstonLogger
):
private readonly logger = new Logger(UsersController.name);
constructor(
private readonly userService: UsersService
) {}
This works because Logger
proxies all of its logging requests to the application logger, in this case WinstonLogger
.
The upside of this is it is clean, easy to write, and very readable.
The downside here is the logger isn't being dependency injected, which is a bit of an ick if you're a DI purist like me. However, practically speaking, in my opinion, this isn't as much of an issue because unit testing your logging is overkill most of the time. Even if you do want to unit test your logs, you can use the Nest hook Logger.overrideLogger()
to replace the logger with a mock logger if necessary.
Would be interested if others think this is the right approach.
from nest-winston.
Related Issues (20)
- Feature request: Add ability to turn off colorization on nestLikeConsoleFormat
- setLogLevels is not a function HOT 2
- Update to allow nest ^9.0.0 HOT 1
- nest-winston v1.6.3 has runtime error ERR_REQUIRE_ESM HOT 11
- Extend the log methods HOT 4
- Log unhandled exceptions in readable form HOT 3
- WinstonLogger suggestions HOT 2
- Write after end node error with winston and nest-winston logger HOT 4
- TypeError: Cannot destructure property 'message' of 'message' as it is null
- Logging NestJS request details with every log? HOT 4
- "Unknown logger level" error when used for bootstraping HOT 3
- Nest can't resolve dependencies HOT 8
- Default context per service (configurable injection scope) HOT 3
- Passing winston logger instance to forRoot doesn't work HOT 2
- [Bug]: Creating multiple winston modules using child winston loggers use the last created winston module when using the nestjs Logger constructor HOT 2
- Adding "level" argument to log method HOT 2
- NestLike ConsoleFormat always contains stringifiedMeta and essentially logs message twice HOT 7
- LoggerService interface changed with Nest v8 HOT 2
- Is there a way to create a child logger? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nest-winston.