Giter Club home page Giter Club logo

Comments (1)

abrindam avatar abrindam commented on July 21, 2024 6

I agree this is a bit confusing and me and my fellow engineers have been tripping over this too.

For what it's worth, here's what we do:

First, register WinstonLogger as the Nest application logger:

import { WinstonModule } from 'nest-winston';

async function bootstrap() {
  const app = await NestFactory.create(AppModule, {
    logger: WinstonModule.createLogger({
      // options (same as WinstonModule.forRoot() options)
    })
  });
  await app.listen(3000);
}
bootstrap();

Then, in the class, manually create an instance of NestJS Logger (not WinstonLogger):

private readonly logger = new Logger(UsersController.name);

constructor(
    private readonly userService: UsersService
) {}

This works because Logger proxies all of its logging requests to the application logger, in this case WinstonLogger.

The upside of this is it is clean, easy to write, and very readable.

The downside here is the logger isn't being dependency injected, which is a bit of an ick if you're a DI purist like me. However, practically speaking, in my opinion, this isn't as much of an issue because unit testing your logging is overkill most of the time. Even if you do want to unit test your logs, you can use the Nest hook Logger.overrideLogger() to replace the logger with a mock logger if necessary.

Would be interested if others think this is the right approach.

from nest-winston.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.