getTimestamp exception thrown when creating Application logger about nest-winston HOT 14 CLOSED

Yep sure, for example in nestjs/terminus, they have created a folder sample be can be called examples IMO. And in it you have 1 folder per example. In each folder, you have a minimal nestjs app with the configuration you want to demonstrate.

For this module, I think we could have multiple examples such as:

• Basic Module configuration (what is explain in Quick start)
• Async Configuration (coupled with the ConfigModule could be a nice real life example)
• Use Logger in Bootstrap
• Configure NestLike formatter
• ...

See https://github.com/nestjs/terminus/tree/master/sample

Maybe create a Pull Request and I'm ok to review & complete the PR if you want.

from nest-winston.

Hi, are you able to setup a minimal repository example?

from nest-winston.

Hi, no problem. I created a barebones project to illustrate the problem. You just need to run it to see the error.
https://github.com/MatthewPeterGreen/nest-winston-issue

from nest-winston.

Like in this issue #275, I get the logger in main.ts with const logger: Logger = app.get(WINSTON_MODULE_NEST_PROVIDER); in it has fixed the issue. Hope it helps.

  await app.listen(port, host, () => {
    const address = configService.get('apiUrl');
    const logger: Logger = app.get(WINSTON_MODULE_NEST_PROVIDER);
    logger.setContext('Main');
    logger.log('Listening at ' + address);
    logger.log('GraphQL at ' + address + '/graphql');
  });

from nest-winston.

@Nightbr good catch!

I can't understand - however - why passing the logger option isn't working, while getting from the service container solved the issue. Any clue? I may update the documentation if we find the exact reason why isn't working.

from nest-winston.

Seems the module initialized the instance so when you override the default logger init with app.useLogger(app.get(WINSTON_MODULE_NEST_PROVIDER));. you need to get the logger with the correct Token WINSTON_MODULE_NEST_PROVIDER otherwise the logger is not defined.

from nest-winston.

I've improved the README, can you both take a look at it and see if the isssue persist?

from nest-winston.

Seems good to me, perhaps a bit complex for new User. Maybe we could create some nestjs boilerplate example with the different configuration? In the code base in an example folder.

from nest-winston.

Thanks for your feedback. Yes I could create a boilerplate code, but I don't know the conventions about it... can you send me some example (maybe other projects)?

from nest-winston.

Thanks, it's a great idea. Should I use the nest cli right?

from nest-winston.

As you want! But the nestcli can help you generate quickly a base app 👌

from nest-winston.

Seems I can't. When running the sample app under the "sample" folder of this project, it doesn't work. I think is something about the TypeScript config (and types conflict). It works when I move the sample outside:

from nest-winston.

Could you create a Pull Request where we can see the code & discuss about this, it will be better to not overflow this issue & be able to see your code & changes. Thanks!

from nest-winston.

@Nightbr you're right, look at #324

from nest-winston.