Giter Club home page Giter Club logo

Comments (2)

sholladay avatar sholladay commented on August 15, 2024

I used the why-is-node-running module to debug this and it pointed a finger at the server.listen() in cycle.js.

I'm not very familiar with this portion of the codebase, but the solutions that seem obvious to me are:

  • Only start listening when the user calls listen() on a Hoxy instance. Otherwise, it is surprising that the program remains open forever.
  • Stop listening / close() at a reasonable time so that graceful shutdown works as expected. Options might be:
    • Handle SIGINT and close.
    • Keep track of whether there are listening hoxy instances. Close when there are no more.
    • Use a class instead of a singleton. Listen / close in tandem with each hoxy instance.

from hoxy.

joaomilho avatar joaomilho commented on August 15, 2024

+1 having this problem. Simple example:

const hoxy = require('hoxy')

const proxy = hoxy.createServer().listen('1234')

proxy.close(function(err) {
  if (err) throw err

  console.log('The proxy is no longer accepting new connections.')
})

The output is The proxy is no longer accepting new connections., but my process is still up.

from hoxy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.