Comments (2)
I used the why-is-node-running module to debug this and it pointed a finger at the server.listen() in cycle.js.
I'm not very familiar with this portion of the codebase, but the solutions that seem obvious to me are:
- Only start listening when the user calls
listen()
on a Hoxy instance. Otherwise, it is surprising that the program remains open forever. - Stop listening /
close()
at a reasonable time so that graceful shutdown works as expected. Options might be:- Handle
SIGINT
and close. - Keep track of whether there are listening hoxy instances. Close when there are no more.
- Use a class instead of a singleton. Listen / close in tandem with each hoxy instance.
- Handle
from hoxy.
+1 having this problem. Simple example:
const hoxy = require('hoxy')
const proxy = hoxy.createServer().listen('1234')
proxy.close(function(err) {
if (err) throw err
console.log('The proxy is no longer accepting new connections.')
})
The output is The proxy is no longer accepting new connections.
, but my process is still up.
from hoxy.
Related Issues (20)
- How to change files stored by cycle.serve HOT 1
- Cannot read property 'port' of null HOT 1
- retrieving ISO-8859-1 webpage encoding problem
- 304 responses fail with as:'json' interceptor HOT 3
- staticServer in Cycle is never being closed.
- Not working with HTTPS HOT 1
- Ignore SSL HOT 1
- Drop Requests
- New maintained Proxy Library
- Proxy Server crashing
- Question: Change target of reverse proxy depending on situation HOT 5
- https with upstream proxy HOT 3
- Promises don't seem to work alongside interception handlers at all HOT 1
- question HOT 2
- has Filter assignment domain?
- Missing [missing_subjectAltName] in ssl certificate in Chrome 58
- How to proxy multiple subdomains HOT 4
- certAuthority filter option
- Port added even if not necessary (http:80 / https:443) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hoxy.