Giter Club home page Giter Club logo

Comments (9)

gregkorossy avatar gregkorossy commented on June 7, 2024 2

It's now available in 24.0.0.1. You can set the bottom margin to 0dp (or whatever you want) by setting preferenceCategory_marginBottom in your theme, for example:

<item name="preferenceCategory_marginBottom">0dp</item>

from android-support-preference-v7-fix.

gregkorossy avatar gregkorossy commented on June 7, 2024 1

Well, the library was buggy, so they didn't intend to change this. It is possible to modify the PreferenceCategory's behavior though to enable customization of this through the style attributes. I'll release the solution based on the new v24 lib, so you'll need to use API 24 as your compiler SDK.

from android-support-preference-v7-fix.

nairbspace avatar nairbspace commented on June 7, 2024 1

Tested and working. Nicely done! Thank you for the fix.

from android-support-preference-v7-fix.

gregkorossy avatar gregkorossy commented on June 7, 2024

The latest version (v24.0.0) of the official library seems to be messing with the paddings / margins (that's why I didn't release the v24 fix yet), maybe they realized the same things you did and tried to fix it, with no success. I'll look into it anyways.

from android-support-preference-v7-fix.

nairbspace avatar nairbspace commented on June 7, 2024

Oops forgot to mention this was on v23.4.0.

from android-support-preference-v7-fix.

gregkorossy avatar gregkorossy commented on June 7, 2024

Don't worry, I got it. I'm just saying that the support lib dev team is definitely doing something with the paddings / margins, so your problem maybe won't exist in the future versions. Or they just really messed up the layout this time.

from android-support-preference-v7-fix.

gxcare avatar gxcare commented on June 7, 2024

Is this still working? I am not sure if I did something wrong or it is no longer supported...

from android-support-preference-v7-fix.

gregkorossy avatar gregkorossy commented on June 7, 2024

@giccisw It should. What's wrong?

from android-support-preference-v7-fix.

chenxiaolong avatar chenxiaolong commented on June 7, 2024

I just submitted a fix for this upstream. https://android-review.googlesource.com/c/platform/frameworks/support/+/588653

from android-support-preference-v7-fix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.