c++11 range for and non copyable. about sparsepp HOT 5 CLOSED

@sagaceilo, thank you very much for the report. I'll look into it asap, maybe over the week-end. Would you have a small sample that reproduces the issue? Also what happens, is it a build issue? Also are you using the latest version, I added support for non-copyable objects a couple weeks ago.

from sparsepp.

Hey!
Here is example:

#if 1
#	define SPP_NO_EXCEPTIONS
#	define SPP_NO_RTTI
#	include <sparsepp/sparsepp.h>

	template <typename HashType, typename ObjType>
	using THashMap = spp::sparse_hash_map<HashType, ObjType>;
#endif

#if 0
#	include <sparsehash/sparse_hash_map>

	template <typename HashType, typename ObjType>
	using THashMap = ::google::sparse_hash_map<HashType, ObjType>;
#endif

#if 0
#	include <unordered_map>

	template <typename HashType, typename ObjType>
	using THashMap = std::unordered_map<HashType, ObjType>;
#endif

class CNonCopyable
{
public:
	CNonCopyable( CNonCopyable const & ) = delete;
	const CNonCopyable& operator=( CNonCopyable const & ) = delete;
	CNonCopyable() = default;
};


struct Probe : CNonCopyable
{
	Probe() {}
	Probe( Probe && other ) {}
	void operator=( Probe && other )	{}
};

void main() {
THashMap<uint64_t,Probe> probes;

probes.insert( { 0, Probe() } );

for( auto& it : probes ) {}
}

I've tried cut as many non revelant code I've could. Hope that You will find this helpful. It runs and compiles using std::unordered_map.

from sparsepp.

Thank you @sagaceilo , your sample program is very useful. Somehow, using my versions of gcc and clang (4.8.3 and 3.8 on linux), your sample as-is does not compile even when using std::unordered_map, because of the insert with the initializer_list.

However, it does build with a simple change, replacing:
probes.insert( { 0, Probe() } );
with:
probes.insert( THashMap<uint64_t, Probe>::value_type(27, Probe()) );

I did update sparsepp a few minutes ago, and now your updated sample builds as well with sparsepp. Please let me know if this version is OK with you.

from sparsepp.

Now it works like a charm :) Thank you ;)

from sparsepp.

Great, thanks for letting me know, closing the issue.

from sparsepp.