Giter Club home page Giter Club logo

Comments (3)

chrisui avatar chrisui commented on July 23, 2024

Hey @jeron-diovis.

This is expected until 0.14 lands and it's a warning you can safely ignore for now providing you're using the library as laid out in the "getting started" guide.

In 0.14 context use will be greatly simplified. https://github.com/Chrisui/react-hotkeys/blob/master/docs/getting-started.md#hotkey-map-context

If this is actually causing functional problems I'd be happy to look into it for you.

from react-hotkeys.

jeron-diovis avatar jeron-diovis commented on July 23, 2024

Shame on me, I missed this guide.
Indeed, using mixin did the trick. Thanks for pointing and for quick response.

Actually, while playing with it, I found out that nested hotkeys wasn't what I really need. I thought somehow that if I'll define a top-level HotKeys, then keyboard events, raised in it, will trigger handlers, defined in descendants. That is, I won't need to focus exact children to work with it's handlers (a kind of pubsub, actually).
Not sure it's even possible... But in practice nesting HotKeys only provides an additional abstraction layer between keycodes and business-logic's actions, nothing more.

Anyway, this lib is great. After introducing HOC it will become absolutely amazing, I think)

from react-hotkeys.

chrisui avatar chrisui commented on July 23, 2024

Cheers :)

I'm planning a large update which will bring up the library upto v1.0 when React v0.14 becomes stable to make the most of parent-based context and HoCs etc.

from react-hotkeys.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.