Stop showing the welcome screen in Incognito mode!!! about thegreatsuspender HOT 5 CLOSED

greatsuspender commented on July 21, 2024

Stop showing the welcome screen in Incognito mode!!!

from thegreatsuspender.

Comments (5)

Sethionic commented on July 21, 2024

Echoing the sentiment and confirming the issue.
(Posted on official chrome store page)

My only gripe is that, when enabled for incognito mode, every new instantiation (opening an incognito tab when none are already open) opens a new tab with an explanation of what the app is and takes the focus away from the new tab and its location bar. I use incognito tabs for quick new sessions or testing things quite frequently, so this is a bit irritating.

from thegreatsuspender.

Sethionic commented on July 21, 2024

Upon further inspection, it looks like the code causing the issue is here in background.js :

if (!lastVersion) {
                gsUtils.setGsHistory([]);

                //show welcome screen
                chrome.tabs.create({url: chrome.extension.getURL('welcome.html')});

from:

    function runStartupChecks() {

        var tidyUrls = gsUtils.getOption(gsUtils.TIDY_URLS),
            lastVersion = gsUtils.fetchVersion(),
            curVersion = chrome.runtime.getManifest().version;

        //check for possible crash
        if (!tidyUrls) {
            checkForCrashRecovery();
        }

        //if version has changed then assume initial install or upgrade
        if (lastVersion !== curVersion) {
            gsUtils.setVersion(curVersion);

            //if they are installing for the first time
            if (!lastVersion) {
                gsUtils.setGsHistory([]);

                //show welcome screen
                chrome.tabs.create({url: chrome.extension.getURL('welcome.html')});
            //else if they are upgrading to a new version
            } else {
                //if pre v5 then perform migration
                if (parseFloat(lastVersion) < 5) {
                    gsUtils.performMigration();
                }

                //show update screen
                chrome.tabs.create({url: chrome.extension.getURL('update.html')});
            }
        }

        //inject new content script into all open pages
        reinjectContentScripts();
    }

from thegreatsuspender.