Giter Club home page Giter Club logo

Comments (7)

dfm avatar dfm commented on August 16, 2024 1

I generally expect that a JOSS paper should include some discussion of the software ecosystem context that the project exists within. If there truly aren't any similar projects, then it's fine to check that box, but I would generally expect there to be some comparable software that should be discussed for context. These comparisons certainly don't need to be in-depth, but should be included if at all possible!

from ronswanson.

grburgess avatar grburgess commented on August 16, 2024 1

@volodymyrss I do see this: https://github.com/mbursa/xspec-table-models which is a wrapper to generate an XSPEC fits file, but from an already existing simulation. Either way, I will write something up in a few moments.

from ronswanson.

grburgess avatar grburgess commented on August 16, 2024 1

@volodymyrss I added a few sentences and refs in the statement of need section.

from ronswanson.

grburgess avatar grburgess commented on August 16, 2024

I wasn't really aware if there was something similar.

from ronswanson.

volodymyrss avatar volodymyrss commented on August 16, 2024

According to the guide:

A JOSS review is generally considered incomplete until the reviewer has checked off all of their checkboxes.

and there is this one:

[ ] State of the field: Do the authors describe how this software compares to other commonly-used packages?

So technically I can not "generally" proceed until this is addressed.

On other other hand, in principle, useful software does not need to have such a section to remain useful. But in an ordinary paper one could require it.

What do we do here, @dfm?

Do we expect something like "to the best of the author's knowledge this work is completely unprecedented"?

from ronswanson.

grburgess avatar grburgess commented on August 16, 2024

I could definitely add something about other spectral fitting software existing (xspec, isis, etc.) but wouldn't this be more related to the fitting package than the table building procedure? I'm unaware of anything other than one off solutions for this problem which is why the package was designed. But if there are others out there I'm happy to cite them.

from ronswanson.

volodymyrss avatar volodymyrss commented on August 16, 2024

Ok then, we need a very brief insight from @grburgess on what are other at least remotely comparable solutions.
Or a statement that there are none.
I suppose in a narrow sense, just for astromodels - there are probably none.
But since people achieve something similar in other situations, it could be useful.

from ronswanson.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.