Giter Club home page Giter Club logo

Comments (8)

GrayJack avatar GrayJack commented on June 19, 2024 1

In that case, if most of the code is copied, is just a matter to put his name (with yours too) on the crate and author text 😄

As long there is a proper attribution, I really don't care who made the PR

from coreutils.

muskuloes avatar muskuloes commented on June 19, 2024 1

Alright guys. I'll do it in the week. @bojan88, I'll add your name as author and will appreciate you reviewing the PR 😅.

from coreutils.

muskuloes avatar muskuloes commented on June 19, 2024

Hi @GrayJack , Can I work on this?

from coreutils.

GrayJack avatar GrayJack commented on June 19, 2024

Yes, of course 😄

from coreutils.

muskuloes avatar muskuloes commented on June 19, 2024

Hi, sorry for the inactivity on this issue. I haven't had the time to work on it yet. Also, I've seen that unexpand has already been implemented. So, if @bojan88 (whom I know from another project) wouldn't mind, he can implement this one as well :) .

from coreutils.

bojan88 avatar bojan88 commented on June 19, 2024

Please, feel free to implement it. Of course I don't mind.
I might join for code reviews

from coreutils.

muskuloes avatar muskuloes commented on June 19, 2024

It's best that you do expand as it'll be very similar to unexpand and you already own the code for that. I won't like to have my name on it, if I just mostly copied your code. I'll find some other issue to work on some other time 😉.

from coreutils.

bojan88 avatar bojan88 commented on June 19, 2024

I also don't mind if you copy most of my code.

from coreutils.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.