Comments (10)
Hi @GrayJack, not sure if @FrancisMurillo is working on this. I had few hours to work on this one, please review the PR -#125
from coreutils.
Understood! Focusing on the -f
flag
from coreutils.
Hi, planning to work on this issue. Planning to do the following:
- Create a branch,
cli/seq
frommaster
- Create a
seq
member based onsleep
- Replicate
man seq
in terms of options and documentation - Write code
Any other advice or guidelines such as testing as well?
from coreutils.
Yes one advice
Always drop manually everything that needs to when std::process::exit()
As for testing, I do not have something more strict because we have lots of stuff that the result depends on the running system configuration, and I have no idea how to create tests for these cases.
But overall, everything that are not those cases, I would like tests cases. I usually give very descriptive names for test functions like <function name>_<case>
Example:
I have a function called myfunc
that takes one bool parameter, so my test function names would be myfunc_true
and myfunc_false
I guess that's all that I can think on top of my head
Have fun with the project 😄
from coreutils.
Just missing -f
flag now
from coreutils.
I just notice that when all 3 args are the same (1 1 1, or 2 2 2) it wont print the value
With default seq
seq 1 1 1
Has output of
1
this version only exit without showing the number
from coreutils.
Heya, I'd like to take a crack at adding the -f
flag and fixing this behavior so seq 1 1 1
operates as expected!
from coreutils.
Hi @GrayJack I couldn't reproduce the 1 1 1
problem from the dev branch.
Running seq 1 1 1
returns 1
, as expected, when built using MacOS and Linux targets.
from coreutils.
Hi @lynnpepin, I believe the error in the behavior was fixed on PR #154 , but the -f
flag remains unimplemented
Sorry, I forgot to mention here that the issue was fixed.
from coreutils.
Hey @GrayJack I'm going to call it quits on implementing -f
. Couldn't figure it out, and I've definitely overcommited a bit! I think I need to tackle some more Rust before trying again.
As it stands, a good first issue for anyone else!
from coreutils.
Related Issues (20)
- [BUG] error message format and exist code is not clear HOT 5
- csplit: implement --suppress-matched
- csplit: add option `--elide-empty-files`
- csplit: support option `--suffix-format`
- Touch: Make -d accept more complex date format
- Touch: Implement -t option
- Man pages HOT 1
- Head: support - input HOT 2
- Uniq: Implement -f option HOT 6
- Seq: Implement -f option
- Seq: Missing last number on some cases HOT 3
- Seq : Missing last output on some cases
- Seq: Does not output when FIRST and LAST are the same number
- Seq: parsing arguments not working
- [BUG] `UtmpxSet::system()` shows killed sessions the same as active sessions HOT 13
- Implement shutdown HOT 4
- Packaging support HOT 5
- [BUG] Rmdir: error when -Ip on legit cases HOT 2
- Date: Implement settimeofday HOT 13
- Date: Implement correct parsing of input date HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coreutils.