Implement seq about coreutils HOT 10 OPEN

Hi @GrayJack, not sure if @FrancisMurillo is working on this. I had few hours to work on this one, please review the PR -#125

from coreutils.

Understood! Focusing on the -f flag

from coreutils.

Hi, planning to work on this issue. Planning to do the following:

1. Create a branch, cli/seq from master
2. Create a seq member based on sleep
3. Replicate man seq in terms of options and documentation
4. Write code

Any other advice or guidelines such as testing as well?

from coreutils.

Yes one advice

Always drop manually everything that needs to when std::process::exit()

As for testing, I do not have something more strict because we have lots of stuff that the result depends on the running system configuration, and I have no idea how to create tests for these cases.

But overall, everything that are not those cases, I would like tests cases. I usually give very descriptive names for test functions like <function name>_<case>

Example:
I have a function called myfunc that takes one bool parameter, so my test function names would be myfunc_true and myfunc_false

I guess that's all that I can think on top of my head

Have fun with the project 😄

from coreutils.

Just missing -f flag now

from coreutils.

I just notice that when all 3 args are the same (1 1 1, or 2 2 2) it wont print the value

With default seq

seq 1 1 1

Has output of
1

this version only exit without showing the number

from coreutils.

Heya, I'd like to take a crack at adding the -f flag and fixing this behavior so seq 1 1 1 operates as expected!

from coreutils.

Hi @GrayJack I couldn't reproduce the 1 1 1 problem from the dev branch.

Running seq 1 1 1 returns 1, as expected, when built using MacOS and Linux targets.

from coreutils.

Hi @lynnpepin, I believe the error in the behavior was fixed on PR #154 , but the -f flag remains unimplemented

Sorry, I forgot to mention here that the issue was fixed.

from coreutils.

Hey @GrayJack I'm going to call it quits on implementing -f. Couldn't figure it out, and I've definitely overcommited a bit! I think I need to tackle some more Rust before trying again.

As it stands, a good first issue for anyone else!

from coreutils.