Giter Club home page Giter Club logo

Comments (8)

tjohnman avatar tjohnman commented on August 27, 2024

For future reference, this fork has 3.22 support:
https://github.com/AdrianoML/Chicago95

Thanks @grassmunk for creating this great theme and @AdrianoML for the rewrite to GTK 3.22.

from chicago95.

amlib avatar amlib commented on August 27, 2024

If grassmunk is still around, I can make a pull request

from chicago95.

grassmunk avatar grassmunk commented on August 27, 2024

Hi All,

Yes I'm here, though sporadically, I would love a pull request.

I've also incorporated the changes outlined here: https://www.reddit.com/r/unixporn/comments/68i7ut/xfce_classic_redmond_grey_theme_updated/

from chicago95.

grassmunk avatar grassmunk commented on August 27, 2024

Ok I went and did some testing with Mousepad (one of the first gtk3 apps in ubuntu) with your fork and noticed that it didn't display properly. Here's with Chicago95 current (without your changes):
screen shot 2017-05-03 at 3 11 05 pm

Notice the menus and the arrow keys don't seem to work. And neither does the file selector.

Compare that with the current Chicago95 theme:
screen shot 2017-05-03 at 3 25 54 pm

from chicago95.

amlib avatar amlib commented on August 27, 2024

Are you using gtk 3.18? The changes made for 3.20 unfortunately make it incompatible with previous versions. I've tried it on ubuntu 16.04 which uses gtk 3.18, and it has the same issues, on all gtk3 apps.

We could still try and distribute both versions.

from chicago95.

grassmunk avatar grassmunk commented on August 27, 2024

Good catch. Yeah I was using an older Ubuntu. Just install 17.04 and tested it out. Looks great but had some questions/comments.

  1. When looking at lists (like in Whisker, but alsp in the choose file dialogue for mousepad) there's a thin line between items. Any way to get rid of that line or is that a gtk3 requirements? Here's an example screenshot:
    screenfetch-2017-05-03_21-49-57

  2. There's a 'bevel' around windows interiors. For example look at mousepad and terminal in this screenshot. There's this 2-3 pixel border around the internal window in both when there shouldn't be any.
    screenfetch-2017-05-03_21-48-46

Compare with my example screenshots posted previously which doesn't have the window bevel or compare to screenshot of the original notepad in windows 95.
image

from chicago95.

amlib avatar amlib commented on August 27, 2024

The beleveling was being generated because all those elements are embedded on a notebook. I have now found out that gtk sets a .frame style for notebooks that are supposed to be "floating around" rather than integrated in a window. I've commited a patch where I don't add a frame nor some padding to notebboks without a .frame style. This seems to solve the issue. (although sometimes the effect loked cool)

The horizontal lines showing in view/treeview elements are by design. I don't know why it's showing vertical ones. I might try showing them in a more selective way later.

from chicago95.

grassmunk avatar grassmunk commented on August 27, 2024

Thanks for doing this!

from chicago95.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.