Giter Club home page Giter Club logo

Comments (5)

thedmeyer avatar thedmeyer commented on May 22, 2024 1

@grassedge https://gist.github.com/thedmeyer/8b50362ae71ecbadabb17f8683c70ece

from generate-plantuml-action.

thedmeyer avatar thedmeyer commented on May 22, 2024

Looking through the code. I did not realize this action is relying on an external API...

const res = await axios.get(`http://www.plantuml.com/plantuml/svg/${encoded}`);

from generate-plantuml-action.

grassedge avatar grassedge commented on May 22, 2024

As you see, this action uses PlantUML Server. So it is difficult to refer other files, such as !include expression. 😞

from generate-plantuml-action.

grassedge avatar grassedge commented on May 22, 2024

I think there are two approaches.

  1. Parse !include expression in JavaScript code, and join included files and post it to PlantUML server.
  2. Rewrite to use container runner and run PlantUML itself on this action.

Approach 1 looks bad because it costs much to be maintained. So I will try to do approach 2 when I have a enough time.

from generate-plantuml-action.

thedmeyer avatar thedmeyer commented on May 22, 2024

For my solution, I ended up writing a native implementation and including the plantuml.jar within my repo.

from generate-plantuml-action.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.