Giter Club home page Giter Club logo

Comments (5)

alexsteinerde avatar alexsteinerde commented on May 21, 2024

This issue seems to be introduced to the Foundation library with this commit: apple/swift-corelibs-foundation@75f3bac
I'm not sure if it is possible to make this property public again or if there is a workaround.

from graphql.

alexsteinerde avatar alexsteinerde commented on May 21, 2024

I just saw the official Jira issue for this (https://bugs.swift.org/browse/SR-464). This property is intended to be private. So I think there is no chance in getting this changed back in the Foundation source code.

from graphql.

adam-fowler avatar adam-fowler commented on May 21, 2024

It looks like a lot of this code is based off the JSONEncoder/Decoder from Foundation. The majority of this code (at least in swift-corelibs-foundation) has been rewritten and does not depend on NSNumber anymore. Is it possible to re-write to avoid NSNumber?

from graphql.

alexsteinerde avatar alexsteinerde commented on May 21, 2024

I created a PR that fixes the build issue for me (I used the Dockerfile provided by you).
Please correct me if my solution is wrong.

If a re-write is possible I don't know. I'm not very familiar with the low level code to answer this question.

from graphql.

adam-fowler avatar adam-fowler commented on May 21, 2024

Yeah looks to fix it. I hadn't thought of using CFGetTypeID.
Removing NSNumber will improve performance of the Coders. But I guess that can be done another time.

from graphql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.