The order of PartialSchemas matters for Interfaces, Unions, and ConnectionTypes - is this intentional? about graphiti HOT 9 CLOSED

@d-exclaimation Haha, that's exactly what I did! Great minds think alike!

@cshadek Could you try this #97 and validate that it fixes your Connection issue as well?

from graphiti.

@NeedleInAJayStack I just tried a bunch of orders for Connections, Unions, Types, and Interfaces and they all worked. Nice work!

from graphiti.

I'll take a look at this. I am assuming the problem is about using those types in a query, mutation, or subscription field(s) require them to be declared in a PartialSchema that's ordered before where the fields are

from graphiti.

@d-exclaimation Interesting. It also is an issue if an interface is after a type that implements it.

Got it. I was able to reproduce the issue. I noticed this is also might be a problem with just regular Schema, where intefaces need be declared before any types that uses it.

@NeedleInAJayStack can you verify this? does an interface need to be declared before being used?

from graphiti.

Yeah, I am able to recreate too. Ideally no ordering should be required - I'll look at fixing this tonight. Thanks for reporting @cshadek

from graphiti.

As a side note, I'm really excited to refactor my existing 1500+ line schema and start using PartialSchemas! I've already noticed a lot of improvement with the code completion in the smaller schemas while trying them out.

from graphiti.

After further analysis, it seems to be an issue exclusive to Interfaces, Unions, and ConnectionTypes. These all need to be declared before they are used in a type or query. While not ideal, this is not the end of the world.

from graphiti.

@d-exclaimation Interesting. It also is an issue if an interface is after a type that implements it.

from graphiti.

Yeah, I am able to recreate too. Ideally no ordering should be required - I'll look at fixing this tonight. Thanks for reporting @cshadek

Not sure exactly how to properly fix this, but one idea I had is to sort the component declared by like a priority, for example:

Scalars > Enums > Inputs > Interface > Type (Object) > Union > Query > Mutation > Subscription

I guess this would have not immediately solve the case where something like a Union is referenced by a Type (Object), Interfaces, or other Unions. However, so far this method seems to work

from graphiti.