Giter Club home page Giter Club logo

Comments (2)

wincent avatar wincent commented on May 2, 2024

I'm not really sure I understand what you're asking here, although I see you followed up with #82. Perhaps we should discuss there instead?

from graphql-relay-js.

jnak avatar jnak commented on May 2, 2024

Sorry wrote that before going to bed... It is not specifically related to #82.

My point is that connectionFromArraySlice expects a slice that contains the elements it needs to populate the page. But you cannot know what those elements are without first going through the pagination algorithm. And right now the pagination algorithm is implemented directly in connectionFromArraySlice (vs factored out in its own function).

This leaves with 2 options when constructing the slice to pass to connectionFromArraySlice:

  1. Come up with a heuristics / strategy to easily compute offsetStart and offsetEnd before calling connectionFromArraySlice,
  2. Call connectionFromArraySlice with dummy data to extract offsetStart and offsetEnd, generate a slice based on these params and call again connectionFromArraySlice with the slice

Is this clearer?

If yes, happy to factor out this pagination algorithm (for a bounded array) into its own function :)

from graphql-relay-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.