Giter Club home page Giter Club logo

Comments (6)

wincent avatar wincent commented on May 5, 2024

Updated the title because I saw that the tests actually do run in Travis CI (example: https://travis-ci.org/graphql/graphql-language-service/builds/265356781), so there is something funky with my local install (this after an rm -r * and a clean git checkout . and yarn).

If I can figure out what is locally wrong with my install, can close this one, but will still need to deal with the other issues (the Flow errors, for example).

from graphql-language-service.

wincent avatar wincent commented on May 5, 2024

It's been a while since I worked in this repo and a fair bit has changed since then, so quite possible that i am Doing It Wrong™.

from graphql-language-service.

asiandrummer avatar asiandrummer commented on May 5, 2024

lerna bootstrap --hoist maybe? And I'm aware of the flow errors with not finding packages correctly - this is a known issue in lerna and can be worked around with including flow-typed packages in the top directory. I just didn't find time to do that yet. @wincent

from graphql-language-service.

danez avatar danez commented on May 5, 2024

It happened because yarn automatically links all graphql-langauge-service-* packages to the local package folders and as package.json points to dist/index.js the important thing is to build all packages before running tests, as otherwise an outdated or no dist/index.js file is there. This was fixed in #166 by running lerna run build before the tests.
Now some flow errors appear, but the tests and flow was working when i tried #166, so maybe flow 0.55 changed something.

from graphql-language-service.

asiandrummer avatar asiandrummer commented on May 5, 2024

With [email protected] there is a bug with Object.create and the flowtype for object prototype not matching. We're waiting for a fix in 0.56.0 and will fix graphql package accordingly to properly fix the flow issues, which will mitigate the flow failures in this library (and others such as codemirror-graphql).

from graphql-language-service.

asiandrummer avatar asiandrummer commented on May 5, 2024

Tests are passing now - closing this in favor.

from graphql-language-service.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.