Giter Club home page Giter Club logo

Comments (13)

rmosolgo avatar rmosolgo commented on March 29, 2024

Interesting, do you think any other types could be "summed"?

image

from graphql-js.

charypar avatar charypar commented on March 29, 2024

I suppose Object types could? Although that doesn't seem as useful?

from graphql-js.

rmosolgo avatar rmosolgo commented on March 29, 2024

PostType + CommentType seems like it should be DocumentInterface

from graphql-js.

leebyron avatar leebyron commented on March 29, 2024

This is pretty interesting, and definitely something worth pursuing in future versions of the spec.

Currently, when we run into a case like this, we just define a new interface that's the manually summed interface, and use that as well.

from graphql-js.

leebyron avatar leebyron commented on March 29, 2024

@rmosolgo - Interfaces are the only types that could be summable. Summing two unions doesn't really make sense: it doesn't lend to any change in query expressiveness and you could just define a new union if more types are possible. Summing two object types also doesn't make sense as object types are concrete (like classes in OO land).

from graphql-js.

rmosolgo avatar rmosolgo commented on March 29, 2024

i'm with ya, that's what i was angling for, making one type "summable" doesn't seem like a great fit when interfaces already exist for exactly (er, almost) that purpose

from graphql-js.

charypar avatar charypar commented on March 29, 2024

@leebyron Would it be useful if I tried to do it for the JS implementation, or would you rather have the spec first?

from graphql-js.

leebyron avatar leebyron commented on March 29, 2024

I think this is something we need to discuss at the spec level first. We will probably punt on it for the first version of the spec, but I want to leave room for discussion

from graphql-js.

charypar avatar charypar commented on March 29, 2024

Shall I open the same issue on the spec repo then?

from graphql-js.

leebyron avatar leebyron commented on March 29, 2024

Sure

from graphql-js.

leebyron avatar leebyron commented on March 29, 2024

It would also help if you include some concrete (non contrived) use cases you're trying to support to help work through useful discussion

from graphql-js.

charypar avatar charypar commented on March 29, 2024

@leebyron added to to graphql/graphql-spec#48.

from graphql-js.

leebyron avatar leebyron commented on March 29, 2024

Closing here in favor of graphql/graphql-spec#48.

from graphql-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.