Comments (7)
Ran a bisect, discovered the performance degradation was 5caff03 (#3457). Raised #3958
cc: @IvanGoncharov
from graphql-js.
@IvanGoncharov or others on this thread. Can we please organise a release for v16? As per #3967.
I would argue this issue should not be marked complete until consumers can use a fixed version of this security/performance hole, on a stable (non-beta) release channel.
from graphql-js.
👋 Apollo Server maintainer here. Going to follow along on this issue to track updates. For @IvanGoncharov 's sake it would be nice to minimize the reproduction to exclude apollo server (and add certainty that it's a graphql-js
problem).
from graphql-js.
@trevor-scheer I'll look at just testing against graphql-js this week and post an update
from graphql-js.
I've added a minimal graphql-js example in the same repo. You can run it using node graphql-js.mjs
.
The slow parsing performance is still observed here
// 1000 __typename query = Took 1999.3179998397827 milliseconds
// 2000 __typename query = Took 8064.870334148407 milliseconds
We've also reproduced this in a real world scenario on a API and due to it's impact, I consider it a critical issue.
from graphql-js.
It looks like (nearly) all the time is spent in OverlappingFieldsCanBeMergedRule
.
from graphql-js.
Raised #3967 for 16
from graphql-js.
Related Issues (20)
- FieldResolver performance HOT 2
- Inline fragment from an interface to an interface that extends it is invalid
- In GraphQL how to set WriteOnce functionality in specific property in the collection schema HOT 1
- Generator generates alias imports not compatible with TypeScript Type-Only Imports and verbatimModuleSyntax HOT 2
- Printing the @oneOf directive HOT 1
- Allow shallow sorting with lexicographicSortSchema HOT 2
- Passing arguments into the resolvers by just using `buildSchema` and `graphql`? HOT 3
- Error after upgrading from 16.6 to 16.8.1 with globalThis.process.env.NODE_ENV HOT 12
- Add: Link to new api docs in the README of this project.
- Introspection result missing interfaces
- Detect subscription successfully started HOT 1
- Errors thrown when iterating over subscription source event streams (AsyncIterables) should be caught HOT 2
- graphql resolver circular dependency type error (bi-directional relation) HOT 1
- Current main is up to 50% slower than previous major version HOT 10
- Type definition for `DefinitionNode` appears to be wrong HOT 4
- AST: `IntValueNode` and `FloatValueNode` store values as string HOT 2
- Array-type resolvers: an intuitive solution to the n+1 problem HOT 1
- Performance of stack traces in errors results in high response latency (>1 second) HOT 1
- Support for deep input graphs HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphql-js.