Allow configuration of @graphql-tools loaders about graphql-markdown HOT 3 CLOSED

Hi @GuiHash

That's definitively something I have missed when refactoring the schema loaders. Much needed.
I don't see a way to do it without a change in the code. But, a quick way to do it would be to add an optional parameter loaderOptions (default = undefined) that accepts any object type (JSON format), then we can pass it directly to loadSchema() in generateDocFromSchema():

const schema = await loadSchema(
  schemaLocation,
  { loaders: getDocumentLoaders(loaders), }, 
  loaderOptions
);

And enhancing the plugin config loaders format to:

type className = string; // UrlLoader

type moduleName = string; // "@graphql-tools/url-loader"
+ type moduleOptions = { [option: string]: any };
+ type module = { 
+   module: moduleName, 
+   options: moduleOptions | undefined 
+ }

type loaders = {
-  [className: className]: moduleName
+  [className: className]: moduleName | module
}

Please go ahead and submit a PR 🚀

from graphql-markdown.

Released in 1.5.3

from graphql-markdown.

Hey! I'm sorry to revive this, but I don't really understand the implementation there. It seems all the options passed are moved to an object called loaderOptions which is then passed as is into the options that the graphql-tools loader takes. This is how the options look like then:

{
  loaders: [ UrlLoader {} ],
  loaderOptions: { headers: { 'x-api-key': 'xxx' } },
  filterKinds: [ 'OperationDefinition', 'FragmentDefinition' ],
  ignore: [],
  cache: {},
  cwd: '/home/chris/dev/colony/docs',
  sort: true
}

Though I think the loaderOptions need to be merged into this object, not included. Or am I doing anything horribly wrong?

EDIT: It might be a regression. Here's the original PR which merges the loaderOptions:

https://github.com/GuiHash/graphql-markdown/blob/e05985ef57b060dd785db3a02258276247beadc4/src/lib/generator.js#L25-L28

Here's the current code which just passes it in:

from graphql-markdown.