Use string.GetHashCode in ROM about parser HOT 6 CLOSED

MemoryExtensions.Equals just calls SequenceEqual, so no need to use that.

from parser.

However, the GetHashCode method looks to be extremely optimized and a good hash. See this "Marvin" class which is used by the method:

https://github.com/dotnet/runtime/blob/main/src/libraries/System.Private.CoreLib/src/System/Marvin.cs

from parser.

As I said it does not work. See MemoryTests.GetHashCode_Issue . Both net5/net6 tests failed. Such implementation of hash is simply not suitable for our purposes.
"abcabc".AsMemory().Slice(0, 3).GetHashCode() should be equal to "abcabc".AsMemory().Slice(3, 3).GetHashCode() Otherwise, all dictionaries with ROM keys in GraphQL.NET are stopped working correctly.

from parser.

See #203

from parser.

As I said it does not work. See MemoryTests.GetHashCode_Issue . Both net5/net6 tests failed. Such implementation of hash is simply not suitable for our purposes. "abcabc".AsMemory().Slice(0, 3).GetHashCode() should be equal to "abcabc".AsMemory().Slice(3, 3).GetHashCode() Otherwise, all dictionaries with ROM keys in GraphQL.NET are stopped working correctly.

I understand. The suggestion here is to use string.GetHashCode, not ReadOnlyMemory.GetHashCode. It is only available on .NET 6.

string.GetHashCode("abcabc".AsMemory().Slice(0, 3).Span) equals string.GetHashCode("abcabc".AsMemory().Slice(3, 3).Span)

from parser.

🤦 done

from parser.