Giter Club home page Giter Club logo

Comments (5)

sungam3r avatar sungam3r commented on July 30, 2024 1

I close this issue. I agree that it's more appropriate to have such validations in GraphQL.NET repo.

from parser.

Shane32 avatar Shane32 commented on July 30, 2024

I would leave the parsing to the parser and the validation to the validation framework within GraphQL.NET.

What I don’t like is that there is two distinct sets of AST classes - one within the parser and one within GraphQL.NET. You’d think we could create an AST library that both projects can use. Or simply use the parser AST classes for the GraphQL.NET library.

from parser.

sungam3r avatar sungam3r commented on July 30, 2024

I do not like it either. In some issue we have already talked about that with @joemcbride . It seems to me that the second set of AST classes appeared by a design mistake. I don't remember.

from parser.

sungam3r avatar sungam3r commented on July 30, 2024

#166 (comment) and #166 (comment)

from parser.

sungam3r avatar sungam3r commented on July 30, 2024

What I don’t like is that there is two distinct sets of AST classes - one within the parser and one within GraphQL.NET. You’d think we could create an AST library that both projects can use. Or simply use the parser AST classes for the GraphQL.NET library.

Fixed :)

from parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.