Comments (6)
Ended up moving a bunch of stuff around, so letting it back in on our side a little longer before committing.
If you want to give it a shot, i posted the diff real quick here : https://gist.github.com/1777463
(careful of the smtp change if you do / don't use gmail or authentication for your dev install)
This will also add the data array to emails so that if you get a false positive you can send the array along that caused it.
from tattle.
I think this worked.. I'm not seeing the false alerts anymore.
now.. to be sure that I'm seeing the REAL alerts.. :)
On Wed, Feb 8, 2012 at 11:05 PM, Dan Rowe <
[email protected]
wrote:
Ended up moving a bunch of stuff around, so letting it back in on our side
a little longer before committing.If you want to give it a shot, i posted the diff real quick here :
https://gist.github.com/1777463
(careful of the smtp change if you do / don't use gmail or authentication
for your dev install)This will also add the data array to emails so that if you get a false
positive you can send the array along that caused it.
Reply to this email directly or view it on GitHub:
#14 (comment)
from tattle.
K, unfortunately this changed resulted in a '0' status for all checks, even the ones that shouldn't have been 0.
from tattle.
Not sure if this is exactly the same issue I was having...
I prefer not to be notified on status=0, even after the notification interval as passed....
in the current master branch, I changed 1 line in processor.php...
index d480fc6..6abd2ca 100644
--- a/processor.php
+++ b/processor.php
@@ -46,7 +46,7 @@ foreach ($checks as $check) {
fCore::debug("not less then now\n",FALSE);
}
// If It's been more then the Repeat Delay or the Status has changed
- if ($next_check->lt($end) || $check->getLastCheckStatus() != $result) {
- if (($next_check->lt($end) && $result != 0) || $check->getLastCheckStatus() != $result) {
fCore::debug("Send Notification \n",FALSE);
fCore::debug("State :" . $result . ":\n",FALSE);
$check_result = new CheckResult();
from tattle.
I found that there are problems with status in panel too.
<td><?=($row['status'] == 2 ? 'Warning' : 'Error');?></td>
Status 'OK' doesn't exists ...
from tattle.
Fixes and improvements have been done on alerts processing since opening of this issue.
Therefore I close it, but feel free toreopen it if you still see a bug with v1.1.0.
from tattle.
Related Issues (20)
- Add ability for a check to only occur during certain times of the day. HOT 3
- PHP Fatal error: Call to a member function tossIfNoRows() HOT 5
- Remove the moving-average requirement. HOT 3
- It is possible to set someone's password to an empty string. HOT 1
- Special handling for nulls at the very end of a metric. HOT 3
- The movingAverage function operates on samples, not minutes. HOT 4
- Brief errors are not triggering notifications. HOT 8
- targets with " won't alert HOT 1
- Running Tattle HOT 1
- bootstrap update HOT 2
- Introducing a way to reorder graphs HOT 2
- A button to "test email settings" would be great HOT 3
- Split the 'Samples' setting HOT 3
- Best practice to implement processor.php cron job? HOT 2
- false positive threshold alerts with complex targets HOT 3
- Error while trying to run HOT 2
- time offset for checks HOT 6
- need an update sql script from v1.0.0 to v1.1.0 before releasing v1.1.0 HOT 1
- non-ascii characters in most fields (dashboard titles, line labels...) cause broken graphs HOT 1
- double quotes in graphite targets are not supported and the user is not warned in any way
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tattle.