Giter Club home page Giter Club logo

Comments (2)

benjie avatar benjie commented on August 18, 2024
[mathroc] # select * from pg_type where typname = 'not_null_url';
-[ RECORD 1 ]--+-------------
typname        | not_null_url
typnamespace   | 7828650
typowner       | 10
typlen         | -1
typbyval       | f
typtype        | d
typcategory    | S
typispreferred | f
typisdefined   | t
typdelim       | ,
typrelid       | 0
typelem        | 0
typarray       | 0
typinput       | domain_in
typoutput      | varcharout
typreceive     | domain_recv
typsend        | varcharsend
typmodin       | -
typmodout      | -
typanalyze     | -
typalign       | i
typstorage     | x
typnotnull     | t
typbasetype    | 7828651
typtypmod      | -1
typndims       | 0
typcollation   | 100
typdefaultbin  | ยค
typdefault     | ยค
typacl         | ยค

Time: 12.673 ms
[mathroc] # select oid from pg_class where relname = 'page';
   oid
---------
 7828654
(1 row)

Time: 0.634 ms
[mathroc] # select * from pg_attribute where attrelid = 7828654;
 attrelid |    attname    | atttypid | attstattarget | attlen | attnum | attndims | attcacheoff | atttypmod | attbyval | attstorage | attalign | attnotnull | atthasdef | attisdropped | attislocal | attinhcount | attcollation | attacl | attoptions | attfdwoptions
----------+---------------+----------+---------------+--------+--------+----------+-------------+-----------+----------+------------+----------+------------+-----------+--------------+------------+-------------+--------------+--------+------------+---------------
  7828654 | url           |  7828652 |            -1 |     -1 |      1 |        0 |          -1 |        -1 | f        | x          | i        | f          | f         | f            | t          |           0 |          100 | ยค      | ยค          | ยค
  7828654 | canonical_url |  7828651 |            -1 |     -1 |      2 |        0 |          -1 |        -1 | f        | x          | i        | f          | f         | f            | t          |           0 |          100 | ยค      | ยค          | ยค
  7828654 | keywords      |  7828653 |            -1 |     -1 |      3 |        0 |          -1 |        -1 | f        | x          | i        | f          | f         | f            | t          |           0 |          100 | ยค      | ยค          | ยค
(3 rows)

Time: 2.508 ms

Oh cool; so we have typnotnull imported as domainIsNotNull but we don't actually use it anywhere. This should be relatively easy to fix... in fact I think it's as easy as tweaking this one line:

https://github.com/graphile/graphile-build/blob/99e845a6100f6e1697dfaff8f50f0caa91daef61/packages/graphile-build-pg/src/plugins/PgColumnsPlugin.js#L115

so that it factors in && !attr.type.domainIsNotNull

Would love to see a PR for this including this fix and an accompanying test (which may require an addition to the kitchen sink schema).

๐Ÿ‘

from graphile-engine.

benjie avatar benjie commented on August 18, 2024

If you can get a PR in for this before I fix it myself I'll be happy ๐Ÿ‘

from graphile-engine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.