Comments (2)
[mathroc] # select * from pg_type where typname = 'not_null_url';
-[ RECORD 1 ]--+-------------
typname | not_null_url
typnamespace | 7828650
typowner | 10
typlen | -1
typbyval | f
typtype | d
typcategory | S
typispreferred | f
typisdefined | t
typdelim | ,
typrelid | 0
typelem | 0
typarray | 0
typinput | domain_in
typoutput | varcharout
typreceive | domain_recv
typsend | varcharsend
typmodin | -
typmodout | -
typanalyze | -
typalign | i
typstorage | x
typnotnull | t
typbasetype | 7828651
typtypmod | -1
typndims | 0
typcollation | 100
typdefaultbin | ยค
typdefault | ยค
typacl | ยค
Time: 12.673 ms
[mathroc] # select oid from pg_class where relname = 'page';
oid
---------
7828654
(1 row)
Time: 0.634 ms
[mathroc] # select * from pg_attribute where attrelid = 7828654;
attrelid | attname | atttypid | attstattarget | attlen | attnum | attndims | attcacheoff | atttypmod | attbyval | attstorage | attalign | attnotnull | atthasdef | attisdropped | attislocal | attinhcount | attcollation | attacl | attoptions | attfdwoptions
----------+---------------+----------+---------------+--------+--------+----------+-------------+-----------+----------+------------+----------+------------+-----------+--------------+------------+-------------+--------------+--------+------------+---------------
7828654 | url | 7828652 | -1 | -1 | 1 | 0 | -1 | -1 | f | x | i | f | f | f | t | 0 | 100 | ยค | ยค | ยค
7828654 | canonical_url | 7828651 | -1 | -1 | 2 | 0 | -1 | -1 | f | x | i | f | f | f | t | 0 | 100 | ยค | ยค | ยค
7828654 | keywords | 7828653 | -1 | -1 | 3 | 0 | -1 | -1 | f | x | i | f | f | f | t | 0 | 100 | ยค | ยค | ยค
(3 rows)
Time: 2.508 ms
Oh cool; so we have typnotnull
imported as domainIsNotNull
but we don't actually use it anywhere. This should be relatively easy to fix... in fact I think it's as easy as tweaking this one line:
so that it factors in && !attr.type.domainIsNotNull
Would love to see a PR for this including this fix and an accompanying test (which may require an addition to the kitchen sink schema).
๐
from graphile-engine.
If you can get a PR in for this before I fix it myself I'll be happy ๐
from graphile-engine.
Related Issues (20)
- InitObject is typed wrong HOT 4
- [graphql-parse-resolve-info] Fix types or example HOT 3
- Custom functions for `nodeId` in `NodePlugin` HOT 2
- Add depth traversal to `simplifyParsedResolveInfoFragmentWithType` HOT 2
- No Way to Access Request From Resolvers? HOT 1
- [graphile-build]: Types for Build Don't Match Source HOT 4
- graphql-parse-resolve-info scalar fields HOT 2
- Pagination cursors not working for tables with at least one bigint component HOT 6
- Modify column SQL select HOT 1
- graphile/subscriptions-lds does not trigger on DELETE if subscription contains only edges
- Project depends on vulnerable version of jsonwebtoken HOT 2
- graphql-parse-resolve-info - What to do to get the same output like graphql-fields? HOT 5
- Don't silently swallow exceptions in resolveNode HOT 2
- alias a column at mutation time only? HOT 2
- Type with array property triggers error HOT 10
- Error using PG client: "We only support PG clients from a PG pool..." HOT 4
- pg-pubsub call to removeListener looks like it will not work HOT 3
- Provide a type guard to distinguish between ResolveTree and FieldsByTypeName HOT 2
- Multiple services resulting in duplicate codecs for simple types HOT 1
- Defining two types with the same schema should be allowed HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphile-engine.